Issues in SettingController.php (master) - Issues in master - devnile/microboard - Measure and Improve Code Quality continuously with Scrutinizer

Issues (62)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/Controllers/SettingController.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Microboard\Http\Controllers;

use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\RedirectResponse;
use Illuminate\View\View;
use Microboard\Http\Requests\Setting\StoreFormRequest;
use Microboard\Http\Requests\Setting\UpdateFormRequest;
use Microboard\Models\Setting;
use Spatie\MediaLibrary\MediaCollections\Exceptions\FileDoesNotExist;
use Spatie\MediaLibrary\MediaCollections\Exceptions\FileIsTooBig;

class SettingController extends ResourceController
{
    /**
     * Display a listing of the resource.
     *
     * @return View
     * @throws AuthorizationException
     */
    public function index()
    {
        $this->authorize('viewAny', new Setting);
        return view('microboard::settings.index', [
            'groups' => cache()->remember('settings', 25000, function () {
                return Setting::all()->groupBy('group');
            })
        ]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param UpdateFormRequest $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param Setting $setting
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return RedirectResponse
     * @throws AuthorizationException
     */
    public function update()
    {
        $request = resolve($this->getUpdateFormRequest());
        $this->authorize('update', new Setting);

        foreach ($request->get('value') as $id => $value) {
            $setting = tap(Setting::find($id))->update(compact('value'));

            if (in_array($setting->type, ['avatar', 'files'])) {
                if ($setting->type === 'avatar') {
                    $setting->getMedia()->each->delete();
                }

                addMediaTo($setting, 'default', "value.{$setting->id}");
            }
        }

        cache()->forget('settings');

        return redirect()->back();
    }

    /**
     * @param StoreFormRequest $request
     * @param Setting $model
     * @return RedirectResponse
     * @throws FileDoesNotExist
     * @throws FileIsTooBig
     */
    protected function created($request, $model)
    {
        addMediaTo($model, 'default', "value.{$model->id}");

        return redirect()->back();
    }

    /**
     * @return string
     */
    protected function getUpdateFormRequest(): string
    {
        return UpdateFormRequest::class;
    }

    /**
     * @return string
     */
    protected function getModel(): string
    {
        return Setting::class;
    }

    /**
     * @return string
     */
    protected function getStoreFormRequest(): string
    {
        return StoreFormRequest::class;
    }
}


1			<?php
2
3			namespace Microboard\Http\Controllers;
4
5			use Illuminate\Auth\Access\AuthorizationException;
6			use Illuminate\Http\RedirectResponse;
7			use Illuminate\View\View;
8			use Microboard\Http\Requests\Setting\StoreFormRequest;
9			use Microboard\Http\Requests\Setting\UpdateFormRequest;
10			use Microboard\Models\Setting;
11			use Spatie\MediaLibrary\MediaCollections\Exceptions\FileDoesNotExist;
12			use Spatie\MediaLibrary\MediaCollections\Exceptions\FileIsTooBig;
13
14			class SettingController extends ResourceController
15			{
16			/**
17			* Display a listing of the resource.
18			*
19			* @return View
20			* @throws AuthorizationException
21			*/
22			public function index()
23			{
24			$this->authorize('viewAny', new Setting);
25			return view('microboard::settings.index', [
26			'groups' => cache()->remember('settings', 25000, function () {
27			return Setting::all()->groupBy('group');
28			})
29			]);
30			}
31
32			/**
33			* Update the specified resource in storage.
34			*
35			* @param UpdateFormRequest $request
			0 ignored issues – show Bug introduced 2020-07-04 22:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$request`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
36			* @param Setting $setting
			0 ignored issues – show Bug introduced 2020-06-11 21:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$setting`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
37			* @return RedirectResponse
38			* @throws AuthorizationException
39			*/
40			public function update()
41			{
42			$request = resolve($this->getUpdateFormRequest());
43			$this->authorize('update', new Setting);
44
45			foreach ($request->get('value') as $id => $value) {
46			$setting = tap(Setting::find($id))->update(compact('value'));
47
48			if (in_array($setting->type, ['avatar', 'files'])) {
49			if ($setting->type === 'avatar') {
50			$setting->getMedia()->each->delete();
51			}
52
53			addMediaTo($setting, 'default', "value.{$setting->id}");
54			}
55			}
56
57			cache()->forget('settings');
58
59			return redirect()->back();
60			}
61
62			/**
63			* @param StoreFormRequest $request
64			* @param Setting $model
65			* @return RedirectResponse
66			* @throws FileDoesNotExist
67			* @throws FileIsTooBig
68			*/
69			protected function created($request, $model)
70			{
71			addMediaTo($model, 'default', "value.{$model->id}");
72
73			return redirect()->back();
74			}
75
76			/**
77			* @return string
78			*/
79			protected function getUpdateFormRequest(): string
80			{
81			return UpdateFormRequest::class;
82			}
83
84			/**
85			* @return string
86			*/
87			protected function getModel(): string
88			{
89			return Setting::class;
90			}
91
92			/**
93			* @return string
94			*/
95			protected function getStoreFormRequest(): string
96			{
97			return StoreFormRequest::class;
98			}
99			}
100

devnile / microboard

Issues (62)

Security Analysis not enabled

src/Http/Controllers/SettingController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like