StoreFormRequest::rules() - Code Metrics - Inspection of "Update UpdateFormRequest.php" - devnile/microboard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 08375c...9f214f )

by Mohamed

created 2020-06-11 21:29 UTC

StoreFormRequest::rules() A

↳ Parent: StoreFormRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	9
Ratio	100 %

Importance

Changes

Metric	Value
dl	9
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Microboard\Http\Requests\User;

use App\User;
use Illuminate\Foundation\Http\FormRequest;

class StoreFormRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return auth()->user()->can('update', new User);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()

    {
        return [
            'name' => ['required', 'string'],
            'email' => ['required', 'string', 'unique:users'],
            'password' => ['required', 'string', 'min:8', 'confirmed'],
            'role_id' => ['required', 'string', 'exists:roles,id'],
        ];
    }

    /**
     * Get custom messages for validator errors.
     *
     * @return array
     */
    public function messages()
    {
        return trans('microboard::users.fields');
    }
}


1		<?php
2
3		namespace Microboard\Http\Requests\User;
4
5		use App\User;
6		use Illuminate\Foundation\Http\FormRequest;
7
8		class StoreFormRequest extends FormRequest
9		{
10		/**
11		* Determine if the user is authorized to make this request.
12		*
13		* @return bool
14		*/
15		public function authorize()
16		{
17		return auth()->user()->can('update', new User);
		0 ignored issues – show Bug introduced 2020-06-11 21:40 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
18		}
19
20		/**
21		* Get the validation rules that apply to the request.
22		*
23		* @return array
24		*/
25	View Code Duplication	public function rules()
		0 ignored issues – show Duplication introduced 2020-06-11 21:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		{
27		return [
28		'name' => ['required', 'string'],
29		'email' => ['required', 'string', 'unique:users'],
30		'password' => ['required', 'string', 'min:8', 'confirmed'],
31		'role_id' => ['required', 'string', 'exists:roles,id'],
32		];
33		}
34
35		/**
36		* Get custom messages for validator errors.
37		*
38		* @return array
39		*/
40		public function messages()
41		{
42		return trans('microboard::users.fields');
43		}
44		}
45

devnile / microboard

Push — master ( 08375c...9f214f )

StoreFormRequest::rules() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like