MediaLibraryController::store() - Code Metrics - Inspection of "Update dropzone" - devnile/microboard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1a56f9...9378a2 )

by Mohamed

created 2020-06-18 18:54 UTC

MediaLibraryController::store() A

↳ Parent: MediaLibraryController

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	2
dl	0
loc	17
rs	9.7
c	0
b	0
f	0

<?php

namespace Microboard\Http\Controllers;

use Illuminate\Filesystem\Filesystem;
use Illuminate\Http\Request;
use Microboard\Http\Requests\Media\StoreFormRequest;

class MediaLibraryController extends Controller
{
    /**
     * Store a newly created resource in storage.
     *
     * @param StoreFormRequest $request
     * @param Filesystem $files
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(StoreFormRequest $request, Filesystem $files)
    {
        $path = storage_path('tmp');

        if (! $files->isDirectory($path)) {
            $files->makeDirectory($path, 0777, true);
        }

        $file = $request->file('file');

        $file->move($path, $name = uniqid() . '_' . trim($file->getClientOriginalName()));

        return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'name' => $name,
            'original_name' => $file->getClientOriginalName(),
        ]);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param Request $request
     */
    public function destroy(Request $request, Filesystem $files)
    {
        if ($request->has('name') && $files->exists($path = storage_path("tmp/{$request->input('name')}"))) {
            $files->delete($path);
        }

        return response('DONE');
    }
}


1			<?php
2
3			namespace Microboard\Http\Controllers;
4
5			use Illuminate\Filesystem\Filesystem;
6			use Illuminate\Http\Request;
7			use Microboard\Http\Requests\Media\StoreFormRequest;
8
9			class MediaLibraryController extends Controller
10			{
11			/**
12			* Store a newly created resource in storage.
13			*
14			* @param StoreFormRequest $request
15			* @param Filesystem $files
16			* @return \Illuminate\Http\JsonResponse
17			*/
18			public function store(StoreFormRequest $request, Filesystem $files)
19			{
20			$path = storage_path('tmp');
21
22			if (! $files->isDirectory($path)) {
23			$files->makeDirectory($path, 0777, true);
24			}
25
26			$file = $request->file('file');
27
28			$file->move($path, $name = uniqid() . '_' . trim($file->getClientOriginalName()));
29
30			return response()->json([
			0 ignored issues – show Bug introduced 2020-06-18 19:11 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31			'name' => $name,
32			'original_name' => $file->getClientOriginalName(),
33			]);
34			}
35
36			/**
37			* Remove the specified resource from storage.
38			*
39			* @param Request $request
40			*/
41			public function destroy(Request $request, Filesystem $files)
42			{
43			if ($request->has('name') && $files->exists($path = storage_path("tmp/{$request->input('name')}"))) {
44			$files->delete($path);
45			}
46
47			return response('DONE');
48			}
49			}
50

devnile / microboard

Push — master ( 1a56f9...9378a2 )

MediaLibraryController::store() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like