UpdateFormRequest::messages() - Code Metrics - devnile/microboard - Measure and Improve Code Quality continuously with Scrutinizer

UpdateFormRequest::messages() A
last analyzed 2020-11-17 12:23 UTC

↳ Parent: UpdateFormRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Microboard\Http\Requests\User;

use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Support\Facades\Hash;

class UpdateFormRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        $model = resolve('App\\User');
        $user = $model::find($this->route('user'));
        return $user && auth()->user()->can('update', $user);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            'name' => ['required', 'string'],
            'email' => ['required', 'string', 'unique:users,email,' . $this->route('user')],
            'auth_password' => ['nullable', 'required_with:password', 'string', function ($attribute, $value, $fail) {
                if (!Hash::check($value, auth()->user()->password)) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                    $fail(trans('auth.failed'));
                }
            }],
            'password' => ['nullable', 'required_with:auth_password', 'string', 'min:8', 'confirmed'],
            'role_id' => ['required', 'string', 'exists:roles,id'],
        ];
    }

    /**
     * Get custom messages for validator errors.
     *
     * @return array
     */
    public function messages()
    {
        return trans('microboard::users.fields');
    }
}


UpdateFormRequest::messages() A
last analyzed 2020-11-17 12:23 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Microboard\Http\Requests\User;
4
5			use Illuminate\Foundation\Http\FormRequest;
6			use Illuminate\Support\Facades\Hash;
7
8			class UpdateFormRequest extends FormRequest
9			{
10			/**
11			* Determine if the user is authorized to make this request.
12			*
13			* @return bool
14			*/
15			public function authorize()
16			{
17			$model = resolve('App\\User');
18			$user = $model::find($this->route('user'));
19			return $user && auth()->user()->can('update', $user);
			0 ignored issues – show Bug introduced 2020-07-02 18:54 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
20			}
21
22			/**
23			* Get the validation rules that apply to the request.
24			*
25			* @return array
26			*/
27			public function rules()
28			{
29			return [
30			'name' => ['required', 'string'],
31			'email' => ['required', 'string', 'unique:users,email,' . $this->route('user')],
32			'auth_password' => ['nullable', 'required_with:password', 'string', function ($attribute, $value, $fail) {
33			if (!Hash::check($value, auth()->user()->password)) {
			0 ignored issues – show Bug introduced 2020-06-11 21:40 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
34			$fail(trans('auth.failed'));
35			}
36			}],
37			'password' => ['nullable', 'required_with:auth_password', 'string', 'min:8', 'confirmed'],
38			'role_id' => ['required', 'string', 'exists:roles,id'],
39			];
40			}
41
42			/**
43			* Get custom messages for validator errors.
44			*
45			* @return array
46			*/
47			public function messages()
48			{
49			return trans('microboard::users.fields');
50			}
51			}
52

devnile / microboard

UpdateFormRequest::messages() A last analyzed 2020-11-17 12:23 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

UpdateFormRequest::messages() A
last analyzed 2020-11-17 12:23 UTC