deviouspk / larapi

src/Foundation/Observers/CacheObserver.php

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 11.10.18
 * Time: 13:31.
 */

namespace Foundation\Observers;

use Foundation\Abstracts\Observers\Observer;
use Foundation\Traits\Cacheable;

class CacheObserver extends Observer
{
    /**
     * @param Cacheable | \Eloquent $model
     */
    public function created($model)
    {
        $model::cache()->store($model);

It seems like $model can also be of type Foundation\Traits\Cacheable; however, parameter $model of Foundation\Cache\ModelCache::store() does only seem to accept Eloquent, maybe add an additional type check?

    }

    /**
     * @param Cacheable | \Eloquent $model
     */
    public function updated($model)
    {
        $model::cache()->store($model);

It seems like $model can also be of type Foundation\Traits\Cacheable; however, parameter $model of Foundation\Cache\ModelCache::store() does only seem to accept Eloquent, maybe add an additional type check?

    }

    /**
     * @param Cacheable | \Eloquent $model
     */
    public function deleted($model)
    {
        $model::cache()->remove($model->getKey());

It seems like getKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}