UserService::delete() - Code Metrics - Inspection of "notifications finalized & fixed" - deviouspk/larapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 848980...7bc374 )

by Arthur

created 2018-10-15 20:39 UTC

UserService::delete() A

↳ Parent: UserService

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\User\Services;

use Modules\User\Contracts\UserServiceContract;
use Modules\User\Entities\User;
use Modules\User\Events\UserRegisteredEvent;

class UserService implements UserServiceContract
{
    public function find($id): ?User
    {
        return User::find($id);

    }

    public function update($id, $data): ?User
    {
        $user = $this->find($id);
        $user->update($data);
        return $user;
    }

    public function create($data): User
    {
        $user = User::create($data);
        event(new UserRegisteredEvent($user));
        return $user;

    }

    public function delete($id): bool
    {
        return User::destroy($id);

    }

    public function newUser($data): User
    {
        return new User($data);
    }

}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: arthur
5		* Date: 04.10.18
6		* Time: 16:17.
7		*/
8
9		namespace Modules\User\Services;
10
11		use Modules\User\Contracts\UserServiceContract;
12		use Modules\User\Entities\User;
13		use Modules\User\Events\UserRegisteredEvent;
14
15		class UserService implements UserServiceContract
16		{
17	9	public function find($id): ?User
18		{
19	9	return User::find($id);
		0 ignored issues – show Bug Best Practice introduced 2018-10-15 20:43 UTC by Report Bug Copy Issue Report The expression `return Modules\User\Entities\User::find($id)` could return the type `Illuminate\Database\Eloquent\Collection` which is incompatible with the type-hinted return `null\|Modules\User\Entities\User`. Consider adding an additional type-check to rule them out. Loading history...
20		}
21
22		public function update($id, $data): ?User
23		{
24		$user = $this->find($id);
25		$user->update($data);
26		return $user;
27		}
28
29		public function create($data): User
30		{
31		$user = User::create($data);
32		event(new UserRegisteredEvent($user));
33		return $user;
		0 ignored issues – show Bug Best Practice introduced 2018-10-15 20:43 UTC by Report Bug Copy Issue Report The expression `return $user` could return the type `Illuminate\Database\Eloquent\Model` which includes types incompatible with the type-hinted return `Modules\User\Entities\User`. Consider adding an additional type-check to rule them out. Loading history...
34		}
35
36		public function delete($id): bool
37		{
38		return User::destroy($id);
		0 ignored issues – show Bug Best Practice introduced 2018-10-14 23:15 UTC by Report Bug Copy Issue Report The expression `return Modules\User\Entities\User::destroy($id)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
39		}
40
41	9	public function newUser($data): User
42		{
43	9	return new User($data);
44		}
45
46		}
47

deviouspk / larapi

Push — master ( 848980...7bc374 )

UserService::delete() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like