Modules\Machine\Services\MachineService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	6	1
A	find()	0	3	1
A	delete()	0	3	1
A	create()	0	6	1

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\Machine\Services;

use Modules\Machine\Contracts\MachineServiceContract;
use Modules\Machine\Entities\Machine;
use Modules\Machine\Events\MachineRegisteredEvent;

class MachineService implements MachineServiceContract
{
    public function find($id): ?Machine
    {
        return Machine::find($id);

The expression return Modules\Machine\Entities\Machine::find($id) could return the type Illuminate\Database\Eloquent\Model which includes types incompatible with the type-hinted return null|Modules\Machine\Entities\Machine. Consider adding an additional type-check to rule them out.

    }

    public function update($id, $data): Machine
    {
        $user = $this->find($id);
        $user->update($data);

        return $user;

The expression return $user could return the type null which is incompatible with the type-hinted return Modules\Machine\Entities\Machine. Consider adding an additional type-check to rule them out.

    }

    public function create($data): Machine
    {
        $machine = Machine::create($data);
        event(new MachineRegisteredEvent($machine));

        return $machine;

The expression return $machine could return the type Illuminate\Database\Eloquent\Model which includes types incompatible with the type-hinted return Modules\Machine\Entities\Machine. Consider adding an additional type-check to rule them out.

    }

    public function delete($id): bool
    {
        return Machine::destroy($id);

The expression return Modules\Machine\Entities\Machine::destroy($id) returns the type integer which is incompatible with the type-hinted return boolean.

    }
}