Modules\Machine\Services\MachineService

Complexity

Total Complexity

7

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Test Coverage

Coverage

68.18%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	heartbeat()	0	7	1
A	getByUserId()	0	3	1
A	find()	0	7	2
A	delete()	0	3	1
A	create()	0	6	1
A	update()	0	7	1

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\Machine\Services;

use Carbon\Carbon;
use Modules\Machine\Contracts\MachineServiceContract;
use Modules\Machine\Entities\Machine;
use Modules\Machine\Events\MachineRegisteredEvent;
use Modules\Machine\Events\MachineUpdatedEvent;

class MachineService implements MachineServiceContract
{
    public function getByUserId($userId)
    {
        return Machine::where('user_id', $userId)->get();
    }

    public function find($id): ?Machine
    {
        if ($id instanceof Machine) {
            return $id;
        }

        return Machine::find($id);

The expression return Modules\Machine\Entities\Machine::find($id) could return the type Illuminate\Database\Eloquent\Model|Jenssegers\Mongodb\Eloquent\Model|Modules\Mongo\Abstracts\MongoModel which includes types incompatible with the type-hinted return Modules\Machine\Entities\Machine|null. Consider adding an additional type-check to rule them out.

    }

    public function update($id, $data): Machine
    {
        $machine = $this->find($id);
        $machine->update($data);
        event(new MachineUpdatedEvent($machine));

        return $machine;
    }

    public function create($data): Machine
    {
        $machine = Machine::create($data);
        event(new MachineRegisteredEvent($machine));

        return $machine;

The expression return $machine returns the type Illuminate\Database\Eloquent\Model|Jenssegers\Mongodb\Eloquent\Model|Modules\Mongo\Abstracts\MongoModel which includes types incompatible with the type-hinted return Modules\Machine\Entities\Machine.

    }

    public function delete($id): bool
    {
        return Machine::destroy($id);

The expression return Modules\Machine\Entities\Machine::destroy($id) returns the type integer which is incompatible with the type-hinted return boolean.

    }

    public function heartbeat($id, $data): void
    {
        $this->update($id, [
            'last_heartbeat' => Carbon::now(),
            'memory_usage'   => $data['memory_usage'],
            'cpu_usage'      => $data['cpu_usage'],
            'online'         => true,
        ]);
    }
}