Notification::delete() - Code Metrics - Inspection of "progress sql port" - deviouspk/larapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f218e6...f51c1b )

by Arthur

created 2018-10-27 13:36 UTC

Notification::delete() A

↳ Parent: Notification

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\Machine\Services;

use Modules\Machine\Contracts\NotificationServiceContract;
filter:
    dependency_paths: ["lib/*"]
use Modules\Machine\Entities\Machine;
use Modules\Machine\Events\MachineRegisteredEvent;

class Notification implements NotificationServiceContract
{
    public function find($id): ?Machine
    {
        return Machine::find($id);
    }

    public function update($id, $data): Machine
    {
        $user = $this->find($id);
        $user->update($data);

        return $user;

    }

    public function create($data): Machine
    {
        $machine = Machine::create($data);
        event(new MachineRegisteredEvent($machine));

        return $machine;
    }

    public function delete($id): bool
    {
        return Machine::destroy($id);

    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: arthur
5			* Date: 04.10.18
6			* Time: 16:17.
7			*/
8
9			namespace Modules\Machine\Services;
10
11			use Modules\Machine\Contracts\NotificationServiceContract;
			0 ignored issues – show Bug introduced 2018-10-27 13:41 UTC by Report Bug Copy Issue Report The type `Modules\Machine\Contract...ficationServiceContract` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12			use Modules\Machine\Entities\Machine;
13			use Modules\Machine\Events\MachineRegisteredEvent;
14
15			class Notification implements NotificationServiceContract
16			{
17			public function find($id): ?Machine
18			{
19			return Machine::find($id);
20			}
21
22			public function update($id, $data): Machine
23			{
24			$user = $this->find($id);
25			$user->update($data);
26
27			return $user;
			0 ignored issues – show Bug Best Practice introduced 2018-10-15 23:56 UTC by Report Bug Copy Issue Report The expression `return $user` could return the type `null` which is incompatible with the type-hinted return `Modules\Machine\Entities\Machine`. Consider adding an additional type-check to rule them out. Loading history...
28			}
29
30			public function create($data): Machine
31			{
32			$machine = Machine::create($data);
33			event(new MachineRegisteredEvent($machine));
34
35			return $machine;
36			}
37
38			public function delete($id): bool
39			{
40			return Machine::destroy($id);
			0 ignored issues – show Bug Best Practice introduced 2018-10-15 23:56 UTC by Report Bug Copy Issue Report The expression `return Modules\Machine\E...s\Machine::destroy($id)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
41			}
42			}
43

deviouspk / larapi

Push — master ( f218e6...f51c1b )

Notification::delete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like