SchedulePolicy::create() - Code Metrics - Inspection of "fixing scrutinizer build 5" - deviouspk/larapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 139939...b4b8e8 )

by Arthur

created 2019-03-10 16:46 UTC

SchedulePolicy::create() A

↳ Parent: SchedulePolicy

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	1
dl	0
loc	8
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 12.10.18
 * Time: 01:25.
 */

namespace Modules\Schedule\Policies;

use Foundation\Exceptions\Exception;
use Foundation\Policies\OwnershipPolicy;
use Modules\Schedule\Contracts\ScheduleServiceContract;
use Modules\User\Entities\User;

class SchedulePolicy extends OwnershipPolicy
{
    protected $service;

    /**
     * SchedulePolicy constructor.
     *
     * @param $service
     */
    public function __construct(ScheduleServiceContract $service)
    {
        $this->service = $service;
    }

    public function create(User $user): bool
    {
        $ScheduleCount = $this->service->getByUserId($user->id)->count();

        $maxScheduleCount = 20;

        if ($ScheduleCount > $maxScheduleCount) {
            throw new Exception('You Cannot create more than 20 Schedules. Delete one first', 401);
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: arthur
5			* Date: 12.10.18
6			* Time: 01:25.
7			*/
8
9			namespace Modules\Schedule\Policies;
10
11			use Foundation\Exceptions\Exception;
12			use Foundation\Policies\OwnershipPolicy;
13			use Modules\Schedule\Contracts\ScheduleServiceContract;
14			use Modules\User\Entities\User;
15
16			class SchedulePolicy extends OwnershipPolicy
17			{
18			protected $service;
19
20			/**
21			* SchedulePolicy constructor.
22			*
23			* @param $service
24			*/
25			public function __construct(ScheduleServiceContract $service)
26			{
27			$this->service = $service;
28			}
29
30			public function create(User $user): bool
31			{
32			$ScheduleCount = $this->service->getByUserId($user->id)->count();
33
34			$maxScheduleCount = 20;
35
36			if ($ScheduleCount > $maxScheduleCount) {
37			throw new Exception('You Cannot create more than 20 Schedules. Delete one first', 401);
38			}
			0 ignored issues – show Bug Best Practice introduced 2019-03-10 17:08 UTC by Report Bug Copy Issue Report The function implicitly returns `null` when the `if` condition on line 36 is `false`. This is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
39			}
40			}
41

deviouspk / larapi

Push — master ( 139939...b4b8e8 )

SchedulePolicy::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like