Modules\User\Services\UserService

Complexity

Total Complexity

8

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	6	2
A	update()	0	6	1
A	getCacheTime()	0	3	1
A	find()	0	4	1
A	create()	0	12	2
A	getCacheName()	0	3	1

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\User\Services;

use Cache;
use Modules\User\Contracts\UserServiceContract;
use Modules\User\Entities\User;

class UserService implements UserServiceContract
{
    public function find($id): ?User
    {
        return Cache::remember($this->getCacheName($id), $this->getCacheTime(), function () use ($id) {
            return User::find($id);
        });
    }

    public function update($id, $data): ?User
    {
        $user = $this->find($id);
        $user->update($data);
        \Cache::put($this->getCacheName($id), $user, $this->getCacheTime());
        return $user;
    }

    public function create($data): User
    {
        if (isset($data['_id'])) {
            $user = new User();
            $user->_id = $data['_id'];

The property _id does not exist on Modules\User\Entities\User. Since you implemented __set, consider adding a @property annotation.

            $user->fill($data);
            $user->save();
        } else {
            $user = User::create($data);
        }
        Cache::put($this->getCacheName($user->id), $user, $this->getCacheTime());
        return $user;
    }

    public function delete($id): bool
    {
        $deleted = User::delete($id);

The call to Illuminate\Database\Eloquent\Model::delete() has too many arguments starting with $id.

The method Illuminate\Database\Eloquent\Model::delete() is not static, but was called statically.

        if ($deleted)
            Cache::forget($this->getCacheName($id));
        return $deleted;

The expression return $deleted could return the type null which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }

    protected function getCacheName($id)
    {
        return "user:$id";
    }

    protected function getCacheTime()
    {
        return 60;
    }
}