NotificationController::read() - Code Metrics - Inspection of "should fix travisbuild" - deviouspk/larapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0c5e09...b94ee9 )

by Arthur

created 2018-10-15 18:52 UTC

NotificationController::read() A

↳ Parent: NotificationController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	5
ccs	4
cts	4
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 14.10.18
 * Time: 18:58
 */

namespace Foundation\Controllers;

use Foundation\Resources\NotificationResource;
use Illuminate\Routing\Controller;

class NotificationController extends Controller
{
    public function all()
    {
        return NotificationResource::collection(get_authenticated_user()->notifications);

    }

    public function allUnread()
    {
        return NotificationResource::collection(get_authenticated_user()->unreadNotifications);

    }

    public function read($id)
    {
        get_authenticated_user()->unreadNotifications()->find($id)->markAsRead();
        return response()->json([
            "success"
        ]);
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: arthur
5		* Date: 14.10.18
6		* Time: 18:58
7		*/
8
9		namespace Foundation\Controllers;
10
11		use Foundation\Resources\NotificationResource;
12		use Illuminate\Routing\Controller;
13
14		class NotificationController extends Controller
15		{
16	1	public function all()
17		{
18	1	return NotificationResource::collection(get_authenticated_user()->notifications);
		0 ignored issues – show Bug introduced 2018-10-14 23:15 UTC by Report Bug Copy Issue Report Accessing `notifications` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
19		}
20
21	1	public function allUnread()
22		{
23	1	return NotificationResource::collection(get_authenticated_user()->unreadNotifications);
		0 ignored issues – show Bug introduced 2018-10-14 23:15 UTC by Report Bug Copy Issue Report Accessing `unreadNotifications` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
24		}
25
26	2	public function read($id)
27		{
28	2	get_authenticated_user()->unreadNotifications()->find($id)->markAsRead();
29	2	return response()->json([
30	2	"success"
31		]);
32		}
33		}
34

deviouspk / larapi

Push — master ( 0c5e09...b94ee9 )

NotificationController::read() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like