Modules\User\Services\UserService

Complexity

Total Complexity

11

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Test Coverage

Coverage

28.57%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	newUser()	0	6	1
A	delete()	0	3	1
A	update()	0	6	1
A	find()	0	11	3
A	create()	0	6	1
A	all()	0	3	1
A	findByIdentityId()	0	3	1
A	setRoles()	0	5	2

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\User\Services;

use Modules\Authorization\Entities\Role;
use Modules\User\Contracts\UserServiceContract;
use Modules\User\Entities\User;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class UserService implements UserServiceContract
{
    public function all()
    {
        return User::all();
    }

    public function find($id): ?User
    {
        if ($id instanceof User)
            return $id;

        $user = User::find($id);

        if ($user === null)
            throw new NotFoundHttpException();

        return $user;

The expression return $user could return the type Illuminate\Database\Eloquent\Collection which is incompatible with the type-hinted return Modules\User\Entities\User|null. Consider adding an additional type-check to rule them out.

    }

    public function findByIdentityId($id): ?User
    {
        return User::where('identity_id', $id)->first();
    }

    public function update($id, $data): ?User
    {
        $user = $this->find($id);
        $user->update($data);

        return $user;
    }

    public function create($data): User
    {
        $user = User::create($data);
        $user->assignRole(Role::USER);

        return $user;
    }

    public function delete($id): bool
    {
        return User::destroy($id);

The expression return Modules\User\Entities\User::destroy($id) returns the type integer which is incompatible with the type-hinted return boolean.

    }

    public function newUser($data): User
    {
        $user = new User($data);
        $user->assignRole(Role::USER);

        return $user;
    }

    public function setRoles($id, array $roles): void
    {
        if (!in_array(Role::USER, $roles))
            $roles[] = Role::USER;
        $this->find($id)->syncRoles($roles);
    }
}