Modules\User\Http\Controllers\UserController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Test Coverage

Coverage

33.33%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	3	1
A	__construct()	0	3	1
A	show()	0	3	1
A	update()	0	5	1

<?php

namespace Modules\User\Http\Controllers;

use Foundation\Abstracts\Controller\Controller;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Modules\User\Contracts\UserServiceContract;
use Modules\User\Services\UserService;

class UserController extends Controller
{
    /**
     * @var UserService
     */
    protected $service;

    /**
     * UserController constructor.
     *
     * @param $service
     */
    public function __construct(UserServiceContract $service)
    {
        $this->service = $service;

$service is of type Modules\User\Contracts\UserServiceContract, but the property $service was declared to be of type Modules\User\Services\UserService. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * Display a listing of the resource.
     *
     * @return JsonResponse
     */
    public function index()
    {
        return \response()->json($this->service->all());
    }

    /**
     * Show the specified resource.
     *
     * @return JsonResponse
     */
    public function show()
    {
        return \response()->json(get_authenticated_user()->toArray());
    }

    /**
     * Update the roles in storage.
     *
     * @param Request $request
     *
     * @return JsonResponse
     */
    public function update(Request $request, $id)
    {
        $this->service->assignRole($id, $request->roles);

        return \response()->json('success');
    }
}