Modules\Notification\Http\Controllers\NotificationController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

63.16%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	allUnread()	0	3	1
A	all()	0	3	1
A	read()	0	10	2
A	unread()	0	10	2
A	__construct()	0	3	1

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 14.10.18
 * Time: 18:58.
 */

namespace Modules\Notification\Http\Controllers;

use Illuminate\Routing\Controller;
use Modules\Notification\Contracts\NotificationServiceContract;
use Modules\Notification\Services\NotificationService;
use Modules\Notification\Transformers\NotificationTransformer;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class NotificationController extends Controller
{

    /**
     * @var NotificationService
     */
    protected $service;

    /**
     * NotificationController constructor.
     *
     * @param $service
     */
    public function __construct(NotificationServiceContract $service)
    {
        $this->service = $service;

$service is of type Modules\Notification\Contracts\NotificationServiceContract, but the property $service was declared to be of type Modules\Notification\Services\NotificationService. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    public function all()
    {
        return NotificationTransformer::collection($this->service->allNotificationsByUser(get_authenticated_user()));
    }

    public function allUnread()
    {
        return NotificationTransformer::collection($this->service->unreadNotifcationsByUser(get_authenticated_user()));
    }

    public function read($id)
    {
        if (!$this->service->find($id)->notifiable()->is(auth()->user())) {
            throw new NotFoundHttpException("notification not found");
        }

        $this->service->markAsRead($id);

        return response()->json([
            'success',
        ]);
    }

    public function unread($id)
    {
        if (!$this->service->find($id)->notifiable()->is(auth()->user())) {
            throw new NotFoundHttpException("notification not found");
        }

        $this->service->markAsUnread($id);

        return response()->json([
            'success',
        ]);
    }
}