UserService::all() - Code Metrics - deviouspk/larapi - Measure and Improve Code Quality continuously with Scrutinizer

UserService::all() A
last analyzed 2019-04-15 14:07 UTC

↳ Parent: UserService

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\User\Services;

use Modules\Authorization\Entities\Role;
use Modules\User\Contracts\UserServiceContract;
use Modules\User\Entities\User;
use Modules\User\Events\UserRegisteredEvent;

class UserService implements UserServiceContract
{
    public function all()
    {
        return User::all();
    }

    public function find($id): ?User
    {
        if ($id instanceof User) {
            return $id;
        }

        return User::find($id);

    }

    public function findByIdentityId($id): ?User
    {
        return User::cache()->findBy('identity_id', $id);

    }

    public function update($id, $data): ?User
    {
        $user = $this->find($id);
        $user->update($data);

        return $user;
    }

    public function create($data): User
    {
        $user = User::create($data);
        $user->assignRole(Role::MEMBER);
        event(new UserRegisteredEvent($user));

        return $user;
    }

    public function delete($id): bool
    {
        return User::destroy($id);

    }

    public function newUser($data): User
    {
        $user = new User($data);
        $user->assignRole(Role::MEMBER);

        return $user;
    }

    public function setRoles($id, array $roles): void
    {
        if (! in_array(Role::MEMBER, $roles)) {
            $roles[] = Role::MEMBER;
        }
        $this->find($id)->syncRoles($roles);
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: arthur
5		* Date: 04.10.18
6		* Time: 16:17.
7		*/
8
9		namespace Modules\User\Services;
10
11		use Modules\Authorization\Entities\Role;
12		use Modules\User\Contracts\UserServiceContract;
13		use Modules\User\Entities\User;
14		use Modules\User\Events\UserRegisteredEvent;
15
16		class UserService implements UserServiceContract
17		{
18		public function all()
19		{
20		return User::all();
21		}
22
23		public function find($id): ?User
24		{
25		if ($id instanceof User) {
26		return $id;
27		}
28
29		return User::find($id);
		0 ignored issues – show Bug Best Practice introduced 2018-11-15 22:00 UTC by Report Bug Copy Issue Report The expression `return Modules\User\Entities\User::find($id)` could return the type `Illuminate\Database\Eloquent\Collection` which is incompatible with the type-hinted return `Modules\User\Entities\User\|null`. Consider adding an additional type-check to rule them out. Loading history...
30		}
31
32		public function findByIdentityId($id): ?User
33		{
34		return User::cache()->findBy('identity_id', $id);
		0 ignored issues – show Bug Best Practice introduced 2018-10-29 14:47 UTC by Report Bug Copy Issue Report The expression `return Modules\User\Enti...dBy('identity_id', $id)` could return the type `Eloquent` which includes types incompatible with the type-hinted return `Modules\User\Entities\User\|null`. Consider adding an additional type-check to rule them out. Loading history...
35		}
36
37		public function update($id, $data): ?User
38		{
39		$user = $this->find($id);
40		$user->update($data);
41
42		return $user;
43		}
44
45	1	public function create($data): User
46		{
47	1	$user = User::create($data);
48	1	$user->assignRole(Role::MEMBER);
49	1	event(new UserRegisteredEvent($user));
50
51	1	return $user;
52		}
53
54		public function delete($id): bool
55		{
56		return User::destroy($id);
		0 ignored issues – show Bug Best Practice introduced 2018-10-14 23:15 UTC by Report Bug Copy Issue Report The expression `return Modules\User\Entities\User::destroy($id)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
57		}
58
59		public function newUser($data): User
60		{
61		$user = new User($data);
62		$user->assignRole(Role::MEMBER);
63
64		return $user;
65		}
66
67		public function setRoles($id, array $roles): void
68		{
69		if (! in_array(Role::MEMBER, $roles)) {
70		$roles[] = Role::MEMBER;
71		}
72		$this->find($id)->syncRoles($roles);
73		}
74		}
75

deviouspk / larapi

UserService::all() A last analyzed 2019-04-15 14:07 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

UserService::all() A
last analyzed 2019-04-15 14:07 UTC