Devhelp\PiwikBundle\Command\Param\MethodFinder

Complexity

Total Complexity

11

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	2
A	find()	0	22	3
A	getApi()	0	10	2
A	getApiServiceId()	0	10	2
A	checkIsInstanceOfMethod()	0	12	2

<?php

namespace Devhelp\PiwikBundle\Command\Param;

use Devhelp\Piwik\Api\Api;
use Devhelp\Piwik\Api\Method\Method;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * Finds an api method in a container that is either registered as a service or is available through
 * the given api service by calling getMethod
 */
class MethodFinder
{
    /**
     * @var ContainerInterface
     */
    private $container;

    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(ContainerInterface $container, LoggerInterface $logger = null)
    {
        $this->container = $container;
        $this->logger = $logger ? $logger : new NullLogger();
    }

    /**
     * @param string $methodArg
     * @param string|null $apiName
     * @return Method
     */
    public function find($methodArg, $apiName = null)
    {
        if ($this->container->has($methodArg)) {
            $method = $this->container->get($methodArg);

            $this->logger->debug("$methodArg resolved to a service");

            if ($apiName) {

The expression $apiName of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                $this->logger->warning("'$apiName' api name will be ignored");
            }
        } else {
            $api = $this->getApi($apiName);

            $method = $api->getMethod($methodArg);

            $this->logger->debug("$methodArg resolved to a method name");
        }

        $this->checkIsInstanceOfMethod($methodArg, $method);

        return $method;
    }

    /**
     * @param string|null $apiName
     * @return Api
     */
    private function getApi($apiName)
    {
        $apiServiceId = $this->getApiServiceId($apiName);

        if (!$this->container->has($apiServiceId)) {
            throw new \InvalidArgumentException("'$apiName' api service does not exist");
        }

        return $this->container->get($apiServiceId);
    }

    /**
     * @param string|null $apiName
     * @return string
     */
    private function getApiServiceId($apiName)
    {
        $serviceId = 'devhelp_piwik.api';

        if ($apiName) {

The expression $apiName of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $serviceId .= '.'.$apiName;
        }

        return $serviceId;
    }

    /**
     * @param string $methodArg
     * @param object $method
     */
    private function checkIsInstanceOfMethod($methodArg, $method)
    {
        if (!$method instanceof Method) {
            throw new \InvalidArgumentException(
                sprintf(
                    "'%s' object is of invalid class, expected Devhelp\\Piwik\\Api\\Method\\Method, got %s",
                    $methodArg,
                    get_class($method)
                )
            );
        }
    }
}