Devfaysal\LaravelAdmin\Http\Controllers\PasswordController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	update()	0	20	2

<?php

namespace Devfaysal\LaravelAdmin\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\Session;

class PasswordController extends Controller
{
    public function index()
    {
        return view('laravel-admin::auth.password-change');
    }

    public function update(Request $request)
    {
        if (Hash::check($request->old_password, Auth::user()->password)) {

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $request->validate([

The call to validate() misses a required argument $...$params.

                'new_password' => 'required|confirmed|min:6',
            ]);
            
            $user = Auth::user();
            $user->password = Hash::make($request->new_password);

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $user->save();

            Auth::logout();

            return redirect()->route('admins.login');
        }else{
            Session::flash('message', 'Old Password Does not match!'); 
            Session::flash('alert-class', 'alert-danger');
            return redirect()->back();
        }
    }

}