Devfaysal\LaravelAdmin\Http\Controllers\AdminController

Complexity

Total Complexity

18

Size/Duplication

Total Lines	146
Duplicated Lines	13.01 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	10	2
A	show()	0	8	1
A	create()	9	9	1
A	store()	0	28	3
A	edit()	10	10	1
A	update()	0	25	4
A	destroy()	0	9	1
A	restore()	0	10	1
A	datatable()	0	24	4

<?php

namespace Devfaysal\LaravelAdmin\Http\Controllers;

use Illuminate\Http\Request;
use Yajra\DataTables\DataTables;
use Spatie\Permission\Models\Role;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\Session;
use Devfaysal\LaravelAdmin\Models\Admin;
use Spatie\Permission\Models\Permission;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Foundation\Validation\ValidatesRequests;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;

class AdminController extends BaseController
{
    use AuthorizesRequests, DispatchesJobs, ValidatesRequests;

    public function index()
    {
        $admins = auth()->user()->hasPermissionTo('manage_trashed_admins', 'admin') ? Admin::withTrashed()->get() : Admin::all();

The method user does only exist in Illuminate\Contracts\Auth\Guard, but not in Illuminate\Contracts\Auth\Factory.

The method get does only exist in Illuminate\Database\Eloquent\Builder and Illuminate\Database\Query\Builder, but not in Illuminate\Database\Eloquent\SoftDeletes.

        return view('laravel-admin::admins.index', [

            'admins' => $admins

        ]);
    }

    public function show(Admin $admin)
    {
        return view('laravel-admin::admins.show', [

            'admin' => $admin

        ]);
    }

    public function create()

This method seems to be duplicated in your project.

    {
        $permissions = Permission::where('guard_name', 'admin')->get();
        $roles = Role::where('guard_name', 'admin')->get();
        return view('laravel-admin::admins.create', [
            'roles' => $roles->pluck('name'),
            'permissions' => $permissions->pluck('name')
        ]);
    }

    public function store(Request $request)
    {
        $request->validate([

The call to validate() misses a required argument $...$params.

            'name' => 'required',
            'email' => 'required|email|unique:admins',
            'password' => 'required',
        ]);

        $admin = Admin::create([
            'name' => $request->name,
            'email' => $request->email,
            'password' => Hash::make($request->password),
        ]);
        
        if($request->roles){
            $admin->assignRole($request->roles);
        }

        if($request->permissions){
            $admin->givePermissionTo($request->permissions);
        }
        

        Session::flash('message', 'Admin created Successfully!!'); 
        Session::flash('alert-class', 'alert-success');

        return redirect('/admin/admins');
    }

    public function edit(Admin $admin)

This method seems to be duplicated in your project.

    {
        $permissions = Permission::where('guard_name', 'admin')->get();
        $roles = Role::where('guard_name', 'admin')->get();
        return view('laravel-admin::admins.edit', [
            'admin' => $admin,
            'roles' => $roles->pluck('name'),
            'permissions' => $permissions->pluck('name')
        ]);
    }

    public function update(Request $request, Admin $admin)
    {
        $attributes = $request->validate([

The call to validate() misses a required argument $...$params.

            'name' => 'required',
            'email' => 'required|email|unique:admins,email,' . $admin->id
        ]);

        if($request->password){
            $attributes['password'] = Hash::make($request->password);
        }

        $admin->update($attributes);

        if($request->roles){
            $admin->syncRoles($request->roles);
        }
        if($request->permissions){
            $admin->syncPermissions($request->permissions);
        }
        
        Session::flash('message', 'Admin updated Successfully!!'); 
        Session::flash('alert-class', 'alert-success');

        return redirect('/admin/admins');
    }

    public function destroy(Admin $admin)
    {
        $admin->delete();

        Session::flash('message', 'Admin deleted Successfully!!'); 
        Session::flash('alert-class', 'alert-success');

        return redirect('/admin/admins');
    }

    public function restore($id)
    {
        $admin = Admin::withTrashed()->findOrFail($id);

The method findOrFail does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\SoftDeletes and Illuminate\Database\Query\Builder.

        $admin->restore();

        Session::flash('message', 'Admin restored Successfully!!'); 
        Session::flash('alert-class', 'alert-success');

        return redirect('/admin/admins');
    }

    public function datatable()
    {
        $admins = auth()->user()->hasPermissionTo('manage_trashed_admins', 'admin') ? Admin::withTrashed()->get() : Admin::all();

The method user does only exist in Illuminate\Contracts\Auth\Guard, but not in Illuminate\Contracts\Auth\Factory.

The method get does only exist in Illuminate\Database\Eloquent\Builder and Illuminate\Database\Query\Builder, but not in Illuminate\Database\Eloquent\SoftDeletes.

        return DataTables::of($admins)
            ->addColumn('action', function($admin) {
                $string = '';
                if($admin->trashed()){
                    $string .= '<a class="btn btn-sm btn-oval btn-warning" href="'. route('admins.restore', $admin->id) .'">Restore</a> ';
                }
                $string .= '<a class="btn btn-sm btn-oval btn-info" href="'. route('admins.edit', $admin->id) .'">Edit</a>';
                $string .= ' <a class="btn btn-sm btn-oval btn-primary" href="'. route('admins.show', $admin->id) .'">Show</a>';
                return $string;
            })
            ->addColumn('roles', function($admin) {
                $string = '';
                foreach ($admin->roles as $role){
                    $string .= '<span class="badge badge-success">'. $role->name .'</span> ';
                }
                return $string;
            })
            ->rawColumns(['action', 'roles'])
            ->make(true);
    }
}