Devfaysal\LaravelAdmin\Http\Controllers\Auth\AuthenticatedSessionController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	4	1
A	store()	0	13	1
A	destroy()	0	10	1

<?php

namespace Devfaysal\LaravelAdmin\Http\Controllers\Auth;

use Carbon\Carbon;
use Devfaysal\LaravelAdmin\Http\Controllers\Controller;
use Devfaysal\LaravelAdmin\Http\Requests\Auth\LoginRequest;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;

class AuthenticatedSessionController extends Controller
{
    /**
     * Display the login view.
     *
     * @return \Illuminate\View\View
     */
    public function create()
    {
        return view('laravel-admin::auth.login');
    }

    /**
     * Handle an incoming authentication request.
     *
     * @param  \App\Http\Requests\Auth\LoginRequest  $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(LoginRequest $request)
    {
        $request->authenticate();

        $request->session()->regenerate();

The method regenerate cannot be called on $request->session() (of type callable).

        $admin = Auth::guard('admin')->user();
        $admin->last_login_at = Carbon::now()->toDateTimeString();

Accessing last_login_at on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $admin->last_login_ip = $request->getClientIp();

Accessing last_login_ip on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $admin->save();

        return redirect()->route('admins.dashboard');
    }

    /**
     * Destroy an authenticated session.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy(Request $request)
    {
        Auth::guard('admin')->logout();

The method logout does only exist in Illuminate\Contracts\Auth\StatefulGuard, but not in Illuminate\Contracts\Auth\Guard.

        $request->session()->invalidate();

The method invalidate cannot be called on $request->session() (of type callable).

        $request->session()->regenerateToken();

The method regenerateToken cannot be called on $request->session() (of type callable).

        return redirect()->route('admins.login');
    }
}