ElasticsearchRepository::all() - Code Metrics - Inspection of "[WIP] PHP7 and new infrastructure" - devemio/elasticsearch-eloquent - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#22)

by Sergey

created 2017-03-17 09:13 UTC

ElasticsearchRepository::all() A

↳ Parent: ElasticsearchRepository

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.3142
c	0
b	0
f	0
cc	3
eloc	16
nc	3
nop	3

<?php

namespace Isswp101\Persimmon\Repository;

use Elasticsearch\Client;
use Elasticsearch\Common\Exceptions\Missing404Exception;
use Isswp101\Persimmon\Collection\ElasticsearchCollection;
use Isswp101\Persimmon\Collection\ICollection;
use Isswp101\Persimmon\CollectionParser\ElasticsearchCollectionParser;
use Isswp101\Persimmon\Contracts\Storable;
use Isswp101\Persimmon\Exceptions\ClassTypeErrorException;
use Isswp101\Persimmon\Exceptions\ModelNotFoundException;
use Isswp101\Persimmon\Model\IElasticsearchModel;
use Isswp101\Persimmon\QueryBuilder\IQueryBuilder;
use Isswp101\Persimmon\Relationship\RelationshipKey;
use Isswp101\Persimmon\Response\ElasticsearchCollectionResponse;
use Isswp101\Persimmon\Response\ElasticsearchItemResponse;

class ElasticsearchRepository implements IRepository
{
    private $client;

    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    public function instantiate(string $class): Storable
    {
        $instance = new $class;
        if (!$instance instanceof IElasticsearchModel) {
            throw new ClassTypeErrorException(IElasticsearchModel::class);
        }
        return $instance;
    }

    protected function fill(Storable $model, ElasticsearchItemResponse $response)
    {
        $model->fill($response->source());
        $relationshipKey = new RelationshipKey($response->id(), $response->parent());
        $model->setPrimaryKey($relationshipKey->build());
    }

    public function find(string $id, string $class, array $columns = []): ?Storable
    {
        $model = $this->instantiate($class);
        $relationshipKey = RelationshipKey::parse($id);
        $collection = new ElasticsearchCollectionParser($model->getCollection());
        $params = [
            'index' => $collection->getIndex(),
            'type' => $collection->getType(),
            'id' => $relationshipKey->getId(),
            'parent' => $relationshipKey->getParentId(),
            '_source' => $columns
        ];
        try {
            $response = new ElasticsearchItemResponse($this->client->get($params));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (Missing404Exception $e) {
            throw new ModelNotFoundException($class, $id);
        }
        $this->fill($model, $response);
        return $model;
    }

    public function all(IQueryBuilder $query, string $class, callable $callback = null): ICollection
    {
        $model = $this->instantiate($class);
        $collection = new ElasticsearchCollectionParser($model->getCollection());
        $params = [
            'index' => $collection->getIndex(),
            'type' => $collection->getType(),
            'body' => $query->build()
        ];
        $response = new ElasticsearchCollectionResponse($this->client->search($params));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $models = new ElasticsearchCollection([], $response);
        foreach ($response->hits() as $hit) {
            $model = $this->instantiate($class);
            $this->fill($model, new ElasticsearchItemResponse($hit));
            if ($callback != null) {
                $callback($model);
            }
            $models->put($model->getPrimaryKey(), $model);
        }
        return $models;
    }

    public function insert(Storable $model)
    {
        $relationshipKey = RelationshipKey::parse($model->getPrimaryKey());
        $collection = new ElasticsearchCollectionParser($model->getCollection());
        $params = [
            'index' => $collection->getIndex(),
            'type' => $collection->getType(),
            'id' => $relationshipKey->getId(),
            'parent' => $relationshipKey->getParentId(),
            'body' => $model->toArray()
        ];
        $this->client->index($params);
    }

    public function update(Storable $model)
    {
        $relationshipKey = RelationshipKey::parse($model->getPrimaryKey());
        $collection = new ElasticsearchCollectionParser($model->getCollection());
        $params = [
            'index' => $collection->getIndex(),
            'type' => $collection->getType(),
            'id' => $relationshipKey->getId(),
            'parent' => $relationshipKey->getParentId(),
            'body' => $model->toArray()
        ];
        $this->client->index($params);
    }

    public function delete(Storable $model)
    {
        $relationshipKey = RelationshipKey::parse($model->getPrimaryKey());
        $collection = new ElasticsearchCollectionParser($model->getCollection());
        $params = [
            'index' => $collection->getIndex(),
            'type' => $collection->getType(),
            'id' => $relationshipKey->getId(),
            'parent' => $relationshipKey->getParentId()
        ];
        $this->client->delete($params);
    }
}

1			<?php
2
3			namespace Isswp101\Persimmon\Repository;
4
5			use Elasticsearch\Client;
6			use Elasticsearch\Common\Exceptions\Missing404Exception;
7			use Isswp101\Persimmon\Collection\ElasticsearchCollection;
8			use Isswp101\Persimmon\Collection\ICollection;
9			use Isswp101\Persimmon\CollectionParser\ElasticsearchCollectionParser;
10			use Isswp101\Persimmon\Contracts\Storable;
11			use Isswp101\Persimmon\Exceptions\ClassTypeErrorException;
12			use Isswp101\Persimmon\Exceptions\ModelNotFoundException;
13			use Isswp101\Persimmon\Model\IElasticsearchModel;
14			use Isswp101\Persimmon\QueryBuilder\IQueryBuilder;
15			use Isswp101\Persimmon\Relationship\RelationshipKey;
16			use Isswp101\Persimmon\Response\ElasticsearchCollectionResponse;
17			use Isswp101\Persimmon\Response\ElasticsearchItemResponse;
18
19			class ElasticsearchRepository implements IRepository
20			{
21			private $client;
22
23			public function __construct(Client $client)
24			{
25			$this->client = $client;
26			}
27
28			public function instantiate(string $class): Storable
29			{
30			$instance = new $class;
31			if (!$instance instanceof IElasticsearchModel) {
32			throw new ClassTypeErrorException(IElasticsearchModel::class);
33			}
34			return $instance;
35			}
36
37			protected function fill(Storable $model, ElasticsearchItemResponse $response)
38			{
39			$model->fill($response->source());
40			$relationshipKey = new RelationshipKey($response->id(), $response->parent());
41			$model->setPrimaryKey($relationshipKey->build());
42			}
43
44			public function find(string $id, string $class, array $columns = []): ?Storable
45			{
46			$model = $this->instantiate($class);
47			$relationshipKey = RelationshipKey::parse($id);
48			$collection = new ElasticsearchCollectionParser($model->getCollection());
49			$params = [
50			'index' => $collection->getIndex(),
51			'type' => $collection->getType(),
52			'id' => $relationshipKey->getId(),
53			'parent' => $relationshipKey->getParentId(),
54			'_source' => $columns
55			];
56			try {
57			$response = new ElasticsearchItemResponse($this->client->get($params));
			0 ignored issues – show Documentation introduced 2017-03-07 13:18 UTC by Report Bug Copy Issue Report `$this->client->get($params)` is of type `callable`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58			} catch (Missing404Exception $e) {
59			throw new ModelNotFoundException($class, $id);
60			}
61			$this->fill($model, $response);
62			return $model;
63			}
64
65			public function all(IQueryBuilder $query, string $class, callable $callback = null): ICollection
66			{
67			$model = $this->instantiate($class);
68			$collection = new ElasticsearchCollectionParser($model->getCollection());
69			$params = [
70			'index' => $collection->getIndex(),
71			'type' => $collection->getType(),
72			'body' => $query->build()
73			];
74			$response = new ElasticsearchCollectionResponse($this->client->search($params));
			0 ignored issues – show Documentation introduced 2017-03-07 13:18 UTC by Report Bug Copy Issue Report `$this->client->search($params)` is of type `callable`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
75			$models = new ElasticsearchCollection([], $response);
76			foreach ($response->hits() as $hit) {
77			$model = $this->instantiate($class);
78			$this->fill($model, new ElasticsearchItemResponse($hit));
79			if ($callback != null) {
80			$callback($model);
81			}
82			$models->put($model->getPrimaryKey(), $model);
83			}
84			return $models;
85			}
86
87			public function insert(Storable $model)
88			{
89			$relationshipKey = RelationshipKey::parse($model->getPrimaryKey());
90			$collection = new ElasticsearchCollectionParser($model->getCollection());
91			$params = [
92			'index' => $collection->getIndex(),
93			'type' => $collection->getType(),
94			'id' => $relationshipKey->getId(),
95			'parent' => $relationshipKey->getParentId(),
96			'body' => $model->toArray()
97			];
98			$this->client->index($params);
99			}
100
101			public function update(Storable $model)
102			{
103			$relationshipKey = RelationshipKey::parse($model->getPrimaryKey());
104			$collection = new ElasticsearchCollectionParser($model->getCollection());
105			$params = [
106			'index' => $collection->getIndex(),
107			'type' => $collection->getType(),
108			'id' => $relationshipKey->getId(),
109			'parent' => $relationshipKey->getParentId(),
110			'body' => $model->toArray()
111			];
112			$this->client->index($params);
113			}
114
115			public function delete(Storable $model)
116			{
117			$relationshipKey = RelationshipKey::parse($model->getPrimaryKey());
118			$collection = new ElasticsearchCollectionParser($model->getCollection());
119			$params = [
120			'index' => $collection->getIndex(),
121			'type' => $collection->getType(),
122			'id' => $relationshipKey->getId(),
123			'parent' => $relationshipKey->getParentId()
124			];
125			$this->client->delete($params);
126			}
127			}

devemio / elasticsearch-eloquent

Pull Request — master (#22)

ElasticsearchRepository::all() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like