Paginationable::getNext() - Code Metrics - Inspection of "paginationable" - devemio/elasticsearch-eloquent - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1590a9...f41974 )

by Sergey

created 2016-05-21 22:25 UTC

Paginationable::getNext() A

↳ Parent: Paginationable

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Isswp101\Persimmon\Traits;

use Exception;
use Isswp101\Persimmon\ElasticsearchModel;
use Isswp101\Persimmon\QueryBuilder\QueryBuilder;

trait Paginationable
{
    /**
     * @var ElasticsearchModel
     */
    public $_previous = null;

    /**
     * @var ElasticsearchModel
     */
    public $_next = null;

    /**
     * Search documents and find previous and next documents.
     *
     * @param QueryBuilder $query Query
     * @throws Exception
     */
    public function makePagination(QueryBuilder $query = null)
    {
        if (is_null($this->_position)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            throw new Exception('To use Paginationable trait you must fill _position property in your model');
        }

        /** @var ElasticsearchModel $model */
        $model = static::createInstance();

        $query = $query ?: new QueryBuilder();

        $prevDoc = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $nextDoc = null;

        $query->fields();
        $prevPos = $this->_position - 1;

        if ($prevPos >= 0) {
            $items = $model->search($query->from($prevPos)->size(3));
            $prevDoc = $items->first();
            $items = array_values($items->toArray());
            if (array_key_exists(2, $items)) {
                $nextDoc = $items[2];
            }
        } else {
            $items = $model->search($query->from($this->_position)->size(2));
            $total = $items->getTotal();
            $nextDoc = $items->last();

            $last = $total - 1;
            $items = $model->search($query->from($last)->size(1));
            $prevDoc = $items->first();
        }

        if (!$nextDoc) {
            $items = $model->search($query->from(0)->size(1));
            $nextDoc = $items->first();
        }

        $this->_previous = $prevDoc;
        $this->_next = $nextDoc;
    }

    /**
     * Return previous document.
     *
     * @return ElasticsearchModel
     */
    public function getPrevious()
    {
        return $this->_previous;
    }

    /**
     * Return next document.
     *
     * @return ElasticsearchModel
     */
    public function getNext()
    {
        return $this->_next;
    }
}

1			<?php
2
3			namespace Isswp101\Persimmon\Traits;
4
5			use Exception;
6			use Isswp101\Persimmon\ElasticsearchModel;
7			use Isswp101\Persimmon\QueryBuilder\QueryBuilder;
8
9			trait Paginationable
10			{
11			/**
12			* @var ElasticsearchModel
13			*/
14			public $_previous = null;
15
16			/**
17			* @var ElasticsearchModel
18			*/
19			public $_next = null;
20
21			/**
22			* Search documents and find previous and next documents.
23			*
24			* @param QueryBuilder $query Query
25			* @throws Exception
26			*/
27			public function makePagination(QueryBuilder $query = null)
28			{
29			if (is_null($this->_position)) {
			1 ignored issue – show Bug introduced 2016-05-21 22:40 UTC by Report Bug Copy Issue Report The property `_position` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30			throw new Exception('To use Paginationable trait you must fill _position property in your model');
31			}
32
33			/** @var ElasticsearchModel $model */
34			$model = static::createInstance();
35
36			$query = $query ?: new QueryBuilder();
37
38			$prevDoc = null;
			1 ignored issue – show Unused Code introduced 2016-05-21 22:40 UTC by Report Bug Copy Issue Report `$prevDoc` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
39			$nextDoc = null;
40
41			$query->fields();
42			$prevPos = $this->_position - 1;
43
44			if ($prevPos >= 0) {
45			$items = $model->search($query->from($prevPos)->size(3));
46			$prevDoc = $items->first();
47			$items = array_values($items->toArray());
48			if (array_key_exists(2, $items)) {
49			$nextDoc = $items[2];
50			}
51			} else {
52			$items = $model->search($query->from($this->_position)->size(2));
53			$total = $items->getTotal();
54			$nextDoc = $items->last();
55
56			$last = $total - 1;
57			$items = $model->search($query->from($last)->size(1));
58			$prevDoc = $items->first();
59			}
60
61			if (!$nextDoc) {
62			$items = $model->search($query->from(0)->size(1));
63			$nextDoc = $items->first();
64			}
65
66			$this->_previous = $prevDoc;
67			$this->_next = $nextDoc;
68			}
69
70			/**
71			* Return previous document.
72			*
73			* @return ElasticsearchModel
74			*/
75			public function getPrevious()
76			{
77			return $this->_previous;
78			}
79
80			/**
81			* Return next document.
82			*
83			* @return ElasticsearchModel
84			*/
85			public function getNext()
86			{
87			return $this->_next;
88			}
89			}

devemio / elasticsearch-eloquent

Push — master ( 1590a9...f41974 )

Paginationable::getNext() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like