BelongsToRelationship::get() - Code Metrics - Inspection of "Fix method to create instance from static method" - devemio/elasticsearch-eloquent - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 816340...ab4a72 )

by Sergey

created 2016-06-09 11:01 UTC

BelongsToRelationship::get() B

↳ Parent: BelongsToRelationship

Complexity

Conditions	5
Paths	7

Size

Total Lines	27
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
c	4
b	1
f	0
dl	0
loc	27
ccs	0
cts	17
cp	0
rs	8.439
cc	5
eloc	15
nc	7
nop	0
crap	30

<?php

namespace Isswp101\Persimmon\Relationship;

use Isswp101\Persimmon\ElasticsearchModel;
use Isswp101\Persimmon\Exceptions\ParentModelNotFoundException;

class BelongsToRelationship
{
    /**
     * @var ElasticsearchModel
     */
    protected $child;

    /**
     * @var ElasticsearchModel
     */
    protected $parentClass;

    public function __construct(ElasticsearchModel $child, $parentClass)
    {
        $this->child = $child;
        $this->parentClass = $parentClass;
    }

    /**
     * Associate parent document.
     *
     * @param ElasticsearchModel $parent
     */
    public function associate(ElasticsearchModel $parent)
    {
        $this->child->setParent($parent);
    }

    /**
     * Return parent model.
     *
     * @return ElasticsearchModel|null
     */
    public function get()
    {
        $parent = $this->child->getParent();

        if ($parent) {
            return $parent;
        }

        $parentClass = $this->parentClass;

        $parentId = $this->child->getParentId();

        $innerHits = $this->child->getInnerHits();

        if ($innerHits) {
            $attributes = $innerHits->getParent($parentClass::getType());
            $parent = new $parentClass($attributes);
        } elseif ($parentId) {
            $parent = $parentClass::find($parentId);
        }

        if ($parent) {
            $this->child->setParent($parent);
        }

        return $parent;
    }

    /**
     * Return parent model.
     *
     * @throws ParentModelNotFoundException
     * @return ElasticsearchModel
     */
    public function getOrFail()
    {
        $model = $this->get();

        if (is_null($model)) {
            throw new ParentModelNotFoundException($this->parentClass, $this->child->getParentId());
        }

        return $model;
    }
}


1		<?php
2
3		namespace Isswp101\Persimmon\Relationship;
4
5		use Isswp101\Persimmon\ElasticsearchModel;
6		use Isswp101\Persimmon\Exceptions\ParentModelNotFoundException;
7
8		class BelongsToRelationship
9		{
10		/**
11		* @var ElasticsearchModel
12		*/
13		protected $child;
14
15		/**
16		* @var ElasticsearchModel
17		*/
18		protected $parentClass;
19
20	2	public function __construct(ElasticsearchModel $child, $parentClass)
21		{
22	2	$this->child = $child;
23	2	$this->parentClass = $parentClass;
24	2	}
25
26		/**
27		* Associate parent document.
28		*
29		* @param ElasticsearchModel $parent
30		*/
31	2	public function associate(ElasticsearchModel $parent)
32		{
33	2	$this->child->setParent($parent);
34	2	}
35
36		/**
37		* Return parent model.
38		*
39		* @return ElasticsearchModel\|null
40		*/
41		public function get()
42		{
43		$parent = $this->child->getParent();
44
45		if ($parent) {
46		return $parent;
47		}
48
49		$parentClass = $this->parentClass;
50
51		$parentId = $this->child->getParentId();
52
53		$innerHits = $this->child->getInnerHits();
54
55		if ($innerHits) {
56		$attributes = $innerHits->getParent($parentClass::getType());
57		$parent = new $parentClass($attributes);
58		} elseif ($parentId) {
59		$parent = $parentClass::find($parentId);
60		}
61
62		if ($parent) {
63		$this->child->setParent($parent);
64		}
65
66		return $parent;
67		}
68
69		/**
70		* Return parent model.
71		*
72		* @throws ParentModelNotFoundException
73		* @return ElasticsearchModel
74		*/
75		public function getOrFail()
76		{
77		$model = $this->get();
78
79		if (is_null($model)) {
80		throw new ParentModelNotFoundException($this->parentClass, $this->child->getParentId());
81		}
82
83		return $model;
84		}
85		}
86

devemio / elasticsearch-eloquent

Push — master ( 816340...ab4a72 )

BelongsToRelationship::get() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like