Isswp101\Persimmon\Cache\CacheDecorator::find()

Complexity

Conditions	6
Paths	8

Size

Total Lines	22
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function find(string $id, string $class, array $columns = []): ?Storable
    {
        $hash = $this->getHash($class, $id);
        $model = $this->cacheRepository->find($id, $class, $columns);
        if ($model) {
            if ($columns) {

The expression $columns of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                if (!array_diff($columns, array_keys($model->toArray()))) {
                    return $model;
                }
            } else {
                if ($this->allColumns[$hash] ?? false) {
                    return $model;
                }
            }
        }
        $model = $this->repository->find($id, $class, $columns);
        $this->cacheRepository->update($model);
        if (!$columns) {

The expression $columns of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->allColumns[$hash] = true;
        }
        return $model;
    }
}