Isswp101\Persimmon\ElasticsearchModel

Complexity

Total Complexity

19

Size/Duplication

Total Lines	139
Duplicated Lines	2.88 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	10
Bugs	1	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	injectDependencies()	0	6	1
A	findWithParentId()	0	11	2
A	search()	0	8	2
A	first()	0	9	2
A	firstOrFail()	4	9	2
C	map()	0	29	7
A	all()	0	11	2

<?php

namespace Isswp101\Persimmon;

use Elasticsearch\Client;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Support\Collection;
use Isswp101\Persimmon\Collection\ElasticsearchCollection;
use Isswp101\Persimmon\DAL\ElasticsearchDAL;
use Isswp101\Persimmon\QueryBuilder\QueryBuilder;
use Isswp101\Persimmon\Traits\Elasticsearchable;
use Isswp101\Persimmon\Traits\Mappingable;
use Isswp101\Persimmon\Traits\Relationshipable;
use ReflectionClass;

class ElasticsearchModel extends Model
{
    use Elasticsearchable, Mappingable, Relationshipable;

    /**
     * @var ElasticsearchDAL
     */
    public $_dal;

    public function __construct(array $attributes = [])
    {
        $this->validateIndexAndType();

        parent::__construct($attributes);
    }

    public function injectDependencies()
    {
        // @TODO: move logger to DAL
        $this->injectDataAccessLayer(new ElasticsearchDAL($this, app(Client::class)));
        // $this->injectLogger(app(Log::class));

62% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    public static function findWithParentId($id, $parentId, array $columns = ['*'])
    {
        /** @var static $model */
        $model = parent::find($id, $columns, ['parent_id' => $parentId]);

It seems like you call parent on a different method (find() instead of findWithParentId()). Are you sure this is correct? If so, you might want to change this to $this->find().

        if ($model) {
            $model->setParentId($parentId);
        }

        return $model;
    }

    /**
     * Execute the query and get the result.
     *
     * @param QueryBuilder|array $query
     * @return ElasticsearchCollection|static[]
     */
    public static function search($query = [])
    {
        if ($query instanceof QueryBuilder) {
            $query = $query->build();
        }
        $model = static::createInstance();
        return $model->_dal->search($query);
    }

    /**
     * Execute the query and get the first result.
     *
     * @param QueryBuilder|array $query
     * @return static
     */
    public static function first($query = [])
    {
        if ($query instanceof QueryBuilder) {
            $query = $query->build();
        }
        $query['from'] = 0;
        $query['size'] = 1;
        return static::search($query)->first();
    }

    /**
     * Execute the query and get the first result or throw an exception.
     *
     * @param QueryBuilder|array $query
     * @return static
     * @throws ModelNotFoundException
     */
    public static function firstOrFail($query = [])
    {
        $model = static::first($query);
        if (is_null($model)) {

This code seems to be duplicated across your project.

            $reflect = new ReflectionClass(get_called_class());
            throw new ModelNotFoundException(sprintf('Model `%s` not found', $reflect->getShortName()));
        }
        return $model;
    }

    /**
     * Apply the callback to the documents of the given query.
     *
     * @param QueryBuilder|array $query
     * @param callable $callback
     * @param int $limit
     * @return int hits.total
     */
    public static function map($query = [], callable $callback, $limit = -1)
    {
        if ($query instanceof QueryBuilder) {
            $query = $query->build();
        }

        $query['from'] = array_get($query, 'from', 0);
        $query['size'] = array_get($query, 'size', 50);

        $i = 0;
        $models = static::search($query);
        $total = $models->getTotal();
        while ($models) {
            foreach ($models as $model) {
                $callback($model);
                $i++;
            }

            $query['from'] += $query['size'];

            if ($i >= $total || ($limit > 0 && $i >= $limit)) {
                break;
            }

            $models = static::search($query);
        }

        return $total;
    }

    /**
     * Execute the query and get all items.
     *
     * @param QueryBuilder|array $query
     * @return Collection
     */
    public static function all($query = [])
    {
        if ($query instanceof QueryBuilder) {
            $query = $query->build();
        }
        $collection = collect();
        static::map($query, function (ElasticsearchModel $document) use ($collection) {
            $collection->put($document->getId(), $document);
        });
        return $collection;
    }
}