Isswp101\Persimmon\Cache\CacheDecorator

Complexity

Total Complexity

8

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getHash()	0	4	1
B	find()	0	22	6

<?php

namespace Isswp101\Persimmon\Cache;

use Isswp101\Persimmon\Contracts\Storable;
use Isswp101\Persimmon\Repository\IRepository;

class CacheDecorator
{
    private $repository;
    private $cacheRepository;
    private static $allColumnsHashes = []; // Static is not a good idea

    public function __construct(IRepository $repository, IRepository $cacheRepository)
    {
        $this->repository = $repository;
        $this->cacheRepository = $cacheRepository;
    }

    private function getHash(string $id, string $class): string
    {
        return $class . '@' . $id;
    }

    public function find(string $id, string $class, array $columns = []): ?Storable
    {
        $hash = $this->getHash($id, $class);
        $model = $this->cacheRepository->find($id, $class, $columns);
        if ($model) {
            if ($columns) {

The expression $columns of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                if (!array_diff($columns, array_keys($model->toArray()))) {
                    return $model;
                }
            } else {
                if (CacheDecorator::$allColumnsHashes[$hash] ?? false) {
                    return $model;
                }
            }
        }
        $model = $this->repository->find($id, $class, $columns);
        $this->cacheRepository->update($model);
        if (!$columns) {

The expression $columns of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            CacheDecorator::$allColumnsHashes[$hash] = true;
        }
        return $model;
    }
}