RelationshipTest::testSave() - Code Metrics - Inspection of "[WIP] PHP7 and new infrastructure" - devemio/elasticsearch-eloquent - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#22)

by Sergey

created 2017-03-20 08:36 UTC

RelationshipTest::testSave() B

↳ Parent: RelationshipTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	17

Duplication

Lines	24
Ratio	100 %

Importance

Changes

Metric	Value
dl	24
loc	24
rs	8.9713
c	0
b	0
f	0
cc	1
eloc	17
nc	1
nop	0

<?php

namespace Isswp101\Persimmon\Test;

use Elasticsearch\Common\Exceptions\BadRequest400Exception;
use Elasticsearch\Common\Exceptions\Missing404Exception;
use Isswp101\Persimmon\QueryBuilder\Filters\InnerHitsFilter;
use Isswp101\Persimmon\QueryBuilder\QueryBuilder;
use Isswp101\Persimmon\Test\Models\PurchaseOrder;
use Isswp101\Persimmon\Test\Models\PurchaseOrderLine;

class RelationshipTest extends BaseTestCase
{
    public static function setUpBeforeClass()
    {
        $hash = time() . rand(1, 1000);
        PurchaseOrder::$_index = 'travis_ci_test_parent_child_rel_' . $hash;
        PurchaseOrderLine::$_index = 'travis_ci_test_parent_child_rel_' . $hash;
    }

    public function testPrepareIndex()
    {
        $index = PurchaseOrderLine::getIndex();

        try {
            $this->es->indices()->delete(['index' => $index]);
        } catch (Missing404Exception $e) {

        }

        $this->sleep(3);

        $settings = file_get_contents(__DIR__ . '/index.json');
        $this->es->indices()->create(['index' => $index, 'body' => $settings]);
    }

    public function testSaveWithBadRequest400Exception()
    {
        $po = new PurchaseOrder();
        $po->id = 1;
        $po->name = 'PO1';

        $line = new PurchaseOrderLine();
        $line->id = 1;
        $line->name = 'Line1';

        $this->expectException(BadRequest400Exception::class);

        $po->save();
        $line->save();
    }

    public function testSave()

    {
        $po = new PurchaseOrder();
        $po->id = 1;
        $po->name = 'PO1';

        $line = new PurchaseOrderLine();
        $line->id = 1;
        $line->name = 'Line1';

        $po->save();
        $po->lines()->save($line);

        $poPath = $po->getPath()->toArray();
        $linePath = $line->getPath()->toArray();

        $res = $this->es->get($poPath);
        $this->assertEquals(1, $res['_id']);
        $this->assertEquals('PO1', $res['_source']['name']);

        $res = $this->es->get($linePath);
        $this->assertEquals(1, $res['_id']);
        $this->assertEquals('Line1', $res['_source']['name']);
    }

    public function testAssociate()

    {
        $po = new PurchaseOrder();
        $po->id = 1;
        $po->name = 'PO1';

        $line = new PurchaseOrderLine();
        $line->id = 1;
        $line->name = 'Line1';

        $po->save();
        $line->po()->associate($po);
        $line->save();

        $poPath = $po->getPath()->toArray();
        $linePath = $line->getPath()->toArray();

        $res = $this->es->get($poPath);
        $this->assertEquals(1, $res['_id']);
        $this->assertEquals('PO1', $res['_source']['name']);

        $res = $this->es->get($linePath);
        $this->assertEquals(1, $res['_id']);
        $this->assertEquals('Line1', $res['_source']['name']);
    }

    public function testGetParent()
    {
        $line = PurchaseOrderLine::findWithParentId(1, 1);
        $po = $line->po()->getOrFail();
        $this->assertEquals(1, $line->getParentId());
        $this->assertEquals(1, $po->getId());
    }

    public function testGetChildren()
    {
        $po = PurchaseOrder::findOrFail(1);

        $line = $po->lines()->find(1);
        $this->assertEquals(1, $line->getId());
        $this->assertEquals(1, $line->getParentId());
        $this->assertSame($po, $line->getParent());

        $lines = $po->lines()->get();
        $this->assertEquals(1, $lines->count());
        // $this->assertEquals($line->toArray(), $lines->first()->toArray());

        $this->assertEquals($line->getParent()->toArray(), $lines->first()->getParent()->toArray());
    }

    public function testInnerHits()
    {
        $query = new QueryBuilder();
        $query->filter(new InnerHitsFilter(PurchaseOrderLine::getParentType()));

        $lines = PurchaseOrderLine::search($query);
        $line = $lines->first();
        $this->assertEquals(1, $line->po()->getOrFail()->getId());
    }

    public function testTearDown()
    {
        $this->deleteIndex(PurchaseOrderLine::$_index);
    }
}


1		<?php
2
3		namespace Isswp101\Persimmon\Test;
4
5		use Elasticsearch\Common\Exceptions\BadRequest400Exception;
6		use Elasticsearch\Common\Exceptions\Missing404Exception;
7		use Isswp101\Persimmon\QueryBuilder\Filters\InnerHitsFilter;
8		use Isswp101\Persimmon\QueryBuilder\QueryBuilder;
9		use Isswp101\Persimmon\Test\Models\PurchaseOrder;
10		use Isswp101\Persimmon\Test\Models\PurchaseOrderLine;
11
12		class RelationshipTest extends BaseTestCase
13		{
14		public static function setUpBeforeClass()
15		{
16		$hash = time() . rand(1, 1000);
17		PurchaseOrder::$_index = 'travis_ci_test_parent_child_rel_' . $hash;
18		PurchaseOrderLine::$_index = 'travis_ci_test_parent_child_rel_' . $hash;
19		}
20
21		public function testPrepareIndex()
22		{
23		$index = PurchaseOrderLine::getIndex();
24
25		try {
26		$this->es->indices()->delete(['index' => $index]);
27		} catch (Missing404Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-07 13:18 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
28		}
29
30		$this->sleep(3);
31
32		$settings = file_get_contents(__DIR__ . '/index.json');
33		$this->es->indices()->create(['index' => $index, 'body' => $settings]);
34		}
35
36		public function testSaveWithBadRequest400Exception()
37		{
38		$po = new PurchaseOrder();
39		$po->id = 1;
40		$po->name = 'PO1';
41
42		$line = new PurchaseOrderLine();
43		$line->id = 1;
44		$line->name = 'Line1';
45
46		$this->expectException(BadRequest400Exception::class);
47
48		$po->save();
49		$line->save();
50		}
51
52	View Code Duplication	public function testSave()
		0 ignored issues – show Duplication introduced 2017-03-07 13:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$po = new PurchaseOrder();
55		$po->id = 1;
56		$po->name = 'PO1';
57
58		$line = new PurchaseOrderLine();
59		$line->id = 1;
60		$line->name = 'Line1';
61
62		$po->save();
63		$po->lines()->save($line);
64
65		$poPath = $po->getPath()->toArray();
66		$linePath = $line->getPath()->toArray();
67
68		$res = $this->es->get($poPath);
69		$this->assertEquals(1, $res['_id']);
70		$this->assertEquals('PO1', $res['_source']['name']);
71
72		$res = $this->es->get($linePath);
73		$this->assertEquals(1, $res['_id']);
74		$this->assertEquals('Line1', $res['_source']['name']);
75		}
76
77	View Code Duplication	public function testAssociate()
		0 ignored issues – show Duplication introduced 2017-03-07 13:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		$po = new PurchaseOrder();
80		$po->id = 1;
81		$po->name = 'PO1';
82
83		$line = new PurchaseOrderLine();
84		$line->id = 1;
85		$line->name = 'Line1';
86
87		$po->save();
88		$line->po()->associate($po);
89		$line->save();
90
91		$poPath = $po->getPath()->toArray();
92		$linePath = $line->getPath()->toArray();
93
94		$res = $this->es->get($poPath);
95		$this->assertEquals(1, $res['_id']);
96		$this->assertEquals('PO1', $res['_source']['name']);
97
98		$res = $this->es->get($linePath);
99		$this->assertEquals(1, $res['_id']);
100		$this->assertEquals('Line1', $res['_source']['name']);
101		}
102
103		public function testGetParent()
104		{
105		$line = PurchaseOrderLine::findWithParentId(1, 1);
106		$po = $line->po()->getOrFail();
107		$this->assertEquals(1, $line->getParentId());
108		$this->assertEquals(1, $po->getId());
109		}
110
111		public function testGetChildren()
112		{
113		$po = PurchaseOrder::findOrFail(1);
114
115		$line = $po->lines()->find(1);
116		$this->assertEquals(1, $line->getId());
117		$this->assertEquals(1, $line->getParentId());
118		$this->assertSame($po, $line->getParent());
119
120		$lines = $po->lines()->get();
121		$this->assertEquals(1, $lines->count());
122		// $this->assertEquals($line->toArray(), $lines->first()->toArray());
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-07 13:18 UTC by Report Bug Copy Issue Report `74%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
123		$this->assertEquals($line->getParent()->toArray(), $lines->first()->getParent()->toArray());
124		}
125
126		public function testInnerHits()
127		{
128		$query = new QueryBuilder();
129		$query->filter(new InnerHitsFilter(PurchaseOrderLine::getParentType()));
		0 ignored issues – show Bug introduced 2017-03-10 10:21 UTC by Report Bug Copy Issue Report The method `filter()` does not seem to exist on `object<Isswp101\Persimmo...ryBuilder\QueryBuilder>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
130		$lines = PurchaseOrderLine::search($query);
131		$line = $lines->first();
132		$this->assertEquals(1, $line->po()->getOrFail()->getId());
133		}
134
135		public function testTearDown()
136		{
137		$this->deleteIndex(PurchaseOrderLine::$_index);
138		}
139		}
140

devemio / elasticsearch-eloquent

Pull Request — master (#22)

RelationshipTest::testSave() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like