Isswp101\Persimmon\Relationship\RelationshipKey

Complexity

Total Complexity

6

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getId()	0	4	1
A	getParentId()	0	4	1
A	build()	0	5	2
A	parse()	0	5	1

<?php

namespace Isswp101\Persimmon\Relationship;

class RelationshipKey
{
    const DELIMITER = ':';

    private $id;
    private $parentId;

    public function __construct(string $id, string $parentId = null)
    {
        $this->id = $id;
        $this->parentId = $parentId;
    }

    public function getId(): string
    {
        return $this->id;
    }

    public function getParentId()
    {
        return $this->parentId;
    }

    public function build(): string
    {
        $id = $this->getId();
        return $this->getParentId() != null ? $id . RelationshipKey::DELIMITER . $this->getParentId() : $id;

It seems like you are loosely comparing $this->getParentId() of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

    }

    public static function parse(string $key): RelationshipKey
    {
        $ids = explode(RelationshipKey::DELIMITER, $key);
        return new RelationshipKey($ids[0] ?? null, $ids[1] ?? null);
    }
}