Model::delete() - Code Metrics - Inspection of "Add DAL event emitter" - devemio/elasticsearch-eloquent - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ab4a72...99f0f9 )

by Sergey

created 2016-06-09 11:42 UTC

Model::delete() A

↳ Parent: Model

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3.009

Importance

Changes	3
Bugs	2	Features	0

Metric	Value
c	3
b	2
f	0
dl	0
loc	19
ccs	9
cts	10
cp	0.9
rs	9.4285
cc	3
eloc	10
nc	3
nop	0
crap	3.009

<?php

namespace Isswp101\Persimmon;

use Elasticsearch\Common\Exceptions\Missing404Exception;
use Exception;
use Isswp101\Persimmon\Contracts\Arrayable;
use Isswp101\Persimmon\Contracts\Jsonable;
use Isswp101\Persimmon\Contracts\Stringable;
use Isswp101\Persimmon\DAL\IDAL;
use Isswp101\Persimmon\Exceptions\ModelNotFoundException;
use Isswp101\Persimmon\Traits\Cacheable;
use Isswp101\Persimmon\Traits\Eventable;
use Isswp101\Persimmon\Traits\Fillable;
use Isswp101\Persimmon\Traits\Idable;
use Isswp101\Persimmon\Traits\Mergeable;
use Isswp101\Persimmon\Traits\Presentable;
use Isswp101\Persimmon\Traits\Timestampable;
use Isswp101\Persimmon\Traits\Userable;
use JsonSerializable;

abstract class Model implements Arrayable, Jsonable, Stringable, JsonSerializable
{
    use Presentable, Eventable, Mergeable;
    use Idable, Userable, Timestampable;
    use Fillable, Cacheable;

    /**
     * @var IDAL
     */
    public $_dal;

    /**
     * @var bool
     */
    public $_exist = false;

    /**
     * Create a new instance.
     *
     * @param IDAL $dal
     * @param array $attributes
     */
    public function __construct(IDAL $dal, array $attributes = [])
    {
        $this->_dal = $dal;

        $this->fill($attributes);
    }

    /**
     * {@inheritdoc}
     */
    public function toArray()
    {
        return array_where(get_object_vars($this), function ($key) {
            return !starts_with($key, '_');
        });
    }

    /**
     * {@inheritdoc}
     */
    public function jsonSerialize()
    {
        return $this->toArray();
    }

    /**
     * Save the model.
     *
     * @param array $columns
     * @return bool
     */
    public function save($columns = ['*'])
    {
        $columns = $columns ? (array)$columns : ['*'];

        if ($this->saving() === false) {
            return false;
        }

        $this->fillTimestamp();

        $this->_dal->put($columns);

        $this->_exist = true;

        // self::cache()->put($id, $this);

        if ($this->saved() === false) {
            return false;
        }

        return true;
    }

    /**
     * Delete the model.
     *
     * @return bool
     */
    public function delete()
    {
        if ($this->deleting() === false) {
            return false;
        }

        $this->_dal->delete();

        $this->_exist = false;

        $cache = self::cache();
        $cache->forget($this->getId());

        if ($this->deleted() === false) {
            return false;
        }

        return true;
    }

    /**
     * Create a new instance.
     *
     * @return static
     */
    public static function createInstance()
    {
        return new static(null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Find a model by its primary key.
     *
     * @param mixed $id
     * @param array $columns
     * @param array $options
     * @return static
     */
    public static function find($id, array $columns = ['*'], $options = [])
    {
        // Return a cached instance if one exists
        $cache = self::cache();
        if ($cache->containsAttributes($id, $columns)) {
            return $cache->get($id);
        }

        // Return attributes which are not cached
        $columns = $cache->getNotCachedAttributes($id, $columns);

        // Create a new model
        $model = static::createInstance();
        $model->setId($id);

        // Merge options
        $options = array_merge($options, ['columns' => $columns == ['*'] ? [] : $columns]);

        // Get by id
        try {
            $model->_dal->get($id, $options);
        } catch (Missing404Exception $e) {
            return null;
        }

        // Fill internal attributes
        $model->_exist = true;

        // Put model to cache
        $model = $cache->put($id, $model, $columns);

        return $model;
    }

    /**
     * Find a model by its primary key or return new model.
     *
     * @param mixed $id
     * @return static
     */
    public static function findOrNew($id)
    {
        $model = static::find($id);
        if (is_null($model)) {
            $model = static::createInstance();
            $model->setId($id);
        }
        return $model;
    }

    /**
     * Find a model by its primary key or throw an exception.
     *
     * @param mixed $id
     * @param array $columns
     * @param int $parent
     * @return static
     */
    public static function findOrFail($id, array $columns = ['*'], $parent = null)
    {
        $model = static::find($id, $columns, ['parent' => $parent]);
        if (is_null($model)) {
            throw new ModelNotFoundException(get_called_class(), $id);
        }
        return $model;
    }

    /**
     * Save a new model and return the instance.
     *
     * @param array $attributes
     * @throws Exception
     * @return static
     */
    public static function create(array $attributes = [])
    {
        $model = static::createInstance();

        if (array_key_exists('id', $attributes)) {
            $model->setId($attributes['id']);
        }

        $model->fill($attributes);

        $model->save();

        return $model;
    }

    /**
     * Destroy the models by the given id.
     *
     * @param mixed $id
     */
    public static function destroy($id)
    {
        $ids = is_array($id) ? $id : [$id];
        foreach ($ids as $id) {
            $model = static::find($id);
            if (!is_null($model)) {
                $model->delete();
            }
        }
    }
}


1		<?php
2
3		namespace Isswp101\Persimmon;
4
5		use Elasticsearch\Common\Exceptions\Missing404Exception;
6		use Exception;
7		use Isswp101\Persimmon\Contracts\Arrayable;
8		use Isswp101\Persimmon\Contracts\Jsonable;
9		use Isswp101\Persimmon\Contracts\Stringable;
10		use Isswp101\Persimmon\DAL\IDAL;
11		use Isswp101\Persimmon\Exceptions\ModelNotFoundException;
12		use Isswp101\Persimmon\Traits\Cacheable;
13		use Isswp101\Persimmon\Traits\Eventable;
14		use Isswp101\Persimmon\Traits\Fillable;
15		use Isswp101\Persimmon\Traits\Idable;
16		use Isswp101\Persimmon\Traits\Mergeable;
17		use Isswp101\Persimmon\Traits\Presentable;
18		use Isswp101\Persimmon\Traits\Timestampable;
19		use Isswp101\Persimmon\Traits\Userable;
20		use JsonSerializable;
21
22		abstract class Model implements Arrayable, Jsonable, Stringable, JsonSerializable
23		{
24		use Presentable, Eventable, Mergeable;
25		use Idable, Userable, Timestampable;
26		use Fillable, Cacheable;
27
28		/**
29		* @var IDAL
30		*/
31		public $_dal;
32
33		/**
34		* @var bool
35		*/
36		public $_exist = false;
37
38		/**
39		* Create a new instance.
40		*
41		* @param IDAL $dal
42		* @param array $attributes
43		*/
44	52	public function __construct(IDAL $dal, array $attributes = [])
45		{
46	52	$this->_dal = $dal;
47
48	52	$this->fill($attributes);
49	52	}
50
51		/**
52		* {@inheritdoc}
53		*/
54		public function toArray()
55		{
56	28	return array_where(get_object_vars($this), function ($key) {
57	28	return !starts_with($key, '_');
58	28	});
59		}
60
61		/**
62		* {@inheritdoc}
63		*/
64		public function jsonSerialize()
65		{
66		return $this->toArray();
67		}
68
69		/**
70		* Save the model.
71		*
72		* @param array $columns
73		* @return bool
74		*/
75	24	public function save($columns = ['*'])
76		{
77	24	$columns = $columns ? (array)$columns : ['*'];
78
79	24	if ($this->saving() === false) {
80		return false;
81		}
82
83	24	$this->fillTimestamp();
84
85	24	$this->_dal->put($columns);
86
87	24	$this->_exist = true;
88
89		// self::cache()->put($id, $this);
90
91	24	if ($this->saved() === false) {
92		return false;
93		}
94
95	24	return true;
96		}
97
98		/**
99		* Delete the model.
100		*
101		* @return bool
102		*/
103	6	public function delete()
104		{
105	6	if ($this->deleting() === false) {
106	2	return false;
107		}
108
109	6	$this->_dal->delete();
110
111	6	$this->_exist = false;
112
113	6	$cache = self::cache();
114	6	$cache->forget($this->getId());
115
116	6	if ($this->deleted() === false) {
117		return false;
118		}
119
120	6	return true;
121		}
122
123		/**
124		* Create a new instance.
125		*
126		* @return static
127		*/
128		public static function createInstance()
129		{
130		return new static(null);
		0 ignored issues – show Documentation introduced 2016-06-09 11:47 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `object<Isswp101\Persimmon\DAL\IDAL>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
131		}
132
133		/**
134		* Find a model by its primary key.
135		*
136		* @param mixed $id
137		* @param array $columns
138		* @param array $options
139		* @return static
140		*/
141	22	public static function find($id, array $columns = ['*'], $options = [])
142		{
143		// Return a cached instance if one exists
144	22	$cache = self::cache();
145	22	if ($cache->containsAttributes($id, $columns)) {
146	10	return $cache->get($id);
147		}
148
149		// Return attributes which are not cached
150	14	$columns = $cache->getNotCachedAttributes($id, $columns);
151
152		// Create a new model
153	14	$model = static::createInstance();
154	14	$model->setId($id);
155
156		// Merge options
157	14	$options = array_merge($options, ['columns' => $columns == ['*'] ? [] : $columns]);
158
159		// Get by id
160		try {
161	14	$model->_dal->get($id, $options);
162	14	} catch (Missing404Exception $e) {
163	4	return null;
164		}
165
166		// Fill internal attributes
167	10	$model->_exist = true;
168
169		// Put model to cache
170	10	$model = $cache->put($id, $model, $columns);
171
172	10	return $model;
173		}
174
175		/**
176		* Find a model by its primary key or return new model.
177		*
178		* @param mixed $id
179		* @return static
180		*/
181	2	public static function findOrNew($id)
182		{
183	2	$model = static::find($id);
184	2	if (is_null($model)) {
185	2	$model = static::createInstance();
186	2	$model->setId($id);
187	2	}
188	2	return $model;
189		}
190
191		/**
192		* Find a model by its primary key or throw an exception.
193		*
194		* @param mixed $id
195		* @param array $columns
196		* @param int $parent
197		* @return static
198		*/
199	4	public static function findOrFail($id, array $columns = ['*'], $parent = null)
200		{
201	4	$model = static::find($id, $columns, ['parent' => $parent]);
202	4	if (is_null($model)) {
203	2	throw new ModelNotFoundException(get_called_class(), $id);
204		}
205	2	return $model;
206		}
207
208		/**
209		* Save a new model and return the instance.
210		*
211		* @param array $attributes
212		* @throws Exception
213		* @return static
214		*/
215	8	public static function create(array $attributes = [])
216		{
217	8	$model = static::createInstance();
218
219	8	if (array_key_exists('id', $attributes)) {
220	8	$model->setId($attributes['id']);
221	8	}
222
223	8	$model->fill($attributes);
224
225	8	$model->save();
226
227	8	return $model;
228		}
229
230		/**
231		* Destroy the models by the given id.
232		*
233		* @param mixed $id
234		*/
235	2	public static function destroy($id)
236		{
237	2	$ids = is_array($id) ? $id : [$id];
238	2	foreach ($ids as $id) {
239	2	$model = static::find($id);
240	2	if (!is_null($model)) {
241	2	$model->delete();
242	2	}
243	2	}
244	2	}
245		}
246

devemio / elasticsearch-eloquent

Push — master ( ab4a72...99f0f9 )

Model::delete() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like