Isswp101\Persimmon\DTO\Id

Complexity

Total Complexity

4

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	isPresent()	0	3	1
A	value()	0	3	1
A	undefined()	0	3	1
A	__construct()	0	3	1

<?php

namespace Isswp101\Persimmon\DTO;

final class Id
{
    private int|string|null $value;

The type Isswp101\Persimmon\DTO\null was not found. Maybe you did not declare it correctly or list all dependencies?

    public function __construct(int|string|null $value)
    {
        $this->value = $value;
    }

    public function value(): int|string|null
    {
        return $this->value;
    }

    public function isPresent(): bool
    {
        return $this->value != null;

It seems like you are loosely comparing $this->value of type Isswp101\Persimmon\DTO\null|integer|string against null; this is ambiguous if the integer can be zero. Consider using a strict comparison !== instead.

    }

    public static function undefined(): Id
    {
        return new Id(null);

null of type null is incompatible with the type Isswp101\Persimmon\DTO\null|integer|string expected by parameter $value of Isswp101\Persimmon\DTO\Id::__construct().

    }
}