PaginationServiceProvider::register() - Code Metrics - Inspection of "Update dependencies" - development-x/PaginationServiceProvider - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 679235...86db02 )

by Zlatin

created 2016-07-16 10:16 UTC

PaginationServiceProvider::register() B

↳ Parent: PaginationServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	41
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	1.0098

Importance

Changes	5
Bugs	0	Features	1

Metric	Value
c	5
b	0
f	1
dl	0
loc	41
ccs	22
cts	28
cp	0.7856
rs	8.8571
cc	1
eloc	26
nc	1
nop	1
crap	1.0098

<?php

namespace Pagination;

use Pimple\Container;
use Silex\Application;
use Pimple\ServiceProviderInterface;
use Symfony\Component\Translation\Translator;

class PaginationServiceProvider implements ServiceProviderInterface
{

    public function register(Container $app)
    {

        $app['paginator.options'] = array(
            'offset_page' => 2,
            'page_param' => 'page',
            'items_per_page' => 10,
            'hide_prev_next' => true
        );

        $app['paginator'] = $app->factory(function($app) {

            $app['paginator.options'] = array_replace(array(
                'offset_page' => 2,
                'page_param' => 'page',
                'items_per_page' => 10,
                'hide_prev_next' => true
                    ), $app['paginator.options']);

            return new \Pagination\Util\Paginator($app);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        });

        $app->register(new \Silex\Provider\TwigServiceProvider());
        $app->register(new \Silex\Provider\TranslationServiceProvider());

        $app['twig'] = $app->extend('twig', function(\Twig_Environment $twig) {
            $twig->addExtension(new Twig\TwigExtension());
            return $twig;
        });

        $app['twig.path'] = array_merge_recursive($app['twig.path'], array(
            __DIR__ . DIRECTORY_SEPARATOR . 'Resources' . DIRECTORY_SEPARATOR . 'views'
        ));

        $app['translator'] = $app->extend('translator', function(Translator $translator, Application $app) {

            $translationDirectory = __DIR__ . DIRECTORY_SEPARATOR . 'Resources' . DIRECTORY_SEPARATOR . 'translations';
            $translator->addResource('yaml', $translationDirectory . DIRECTORY_SEPARATOR . 'messages.bg.yml', 'bg');
            $translator->addResource('yaml', $translationDirectory . DIRECTORY_SEPARATOR . 'messages.en.yml', 'en');
            return $translator;
        });
    }

}


1		<?php
2
3		namespace Pagination;
4
5		use Pimple\Container;
6		use Silex\Application;
7		use Pimple\ServiceProviderInterface;
8		use Symfony\Component\Translation\Translator;
9
10		class PaginationServiceProvider implements ServiceProviderInterface
11		{
12
13	5	public function register(Container $app)
14		{
15
16	5	$app['paginator.options'] = array(
17	5	'offset_page' => 2,
18	5	'page_param' => 'page',
19	5	'items_per_page' => 10,
20		'hide_prev_next' => true
21	5	);
22
23		$app['paginator'] = $app->factory(function($app) {
24
25	3	$app['paginator.options'] = array_replace(array(
26	3	'offset_page' => 2,
27	3	'page_param' => 'page',
28	3	'items_per_page' => 10,
29		'hide_prev_next' => true
30	3	), $app['paginator.options']);
31
32	3	return new \Pagination\Util\Paginator($app);
		0 ignored issues – show Documentation introduced 2016-07-16 10:21 UTC by Report Bug Copy Issue Report `$app` is of type `array<string,array<strin...eger\|string\|boolean>"}>`, but the function expects a `object<Silex\Application>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33	5	});
34
35	5	$app->register(new \Silex\Provider\TwigServiceProvider());
36	5	$app->register(new \Silex\Provider\TranslationServiceProvider());
37
38		$app['twig'] = $app->extend('twig', function(\Twig_Environment $twig) {
39		$twig->addExtension(new Twig\TwigExtension());
40		return $twig;
41	5	});
42
43	5	$app['twig.path'] = array_merge_recursive($app['twig.path'], array(
44	5	__DIR__ . DIRECTORY_SEPARATOR . 'Resources' . DIRECTORY_SEPARATOR . 'views'
45	5	));
46
47	5	$app['translator'] = $app->extend('translator', function(Translator $translator, Application $app) {
		0 ignored issues – show Unused Code introduced 2016-05-10 19:26 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
48		$translationDirectory = __DIR__ . DIRECTORY_SEPARATOR . 'Resources' . DIRECTORY_SEPARATOR . 'translations';
49		$translator->addResource('yaml', $translationDirectory . DIRECTORY_SEPARATOR . 'messages.bg.yml', 'bg');
50		$translator->addResource('yaml', $translationDirectory . DIRECTORY_SEPARATOR . 'messages.en.yml', 'en');
51		return $translator;
52	5	});
53	5	}
54
55		}
56

development-x / PaginationServiceProvider

Push — master ( 679235...86db02 )

PaginationServiceProvider::register() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like