Pagination\PaginationServiceProvider

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

77.78%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	register()	0	50	5

<?php

namespace Pagination;

use Pimple\Container;
use Pimple\ServiceProviderInterface;
use Silex\Application;
use Symfony\Component\Translation\Translator;

class PaginationServiceProvider implements ServiceProviderInterface
{
    /**
     * 
     * @param Container $app
     */
    public function register(Container $app)
    {
        $app['paginator.options'] = [
            'offset_page'    => 2,
            'page_param'     => 'page',
            'items_per_page' => 10,
            'hide_prev_next' => true,
        ];

        $app['paginator'] = $app->factory(function ($app) {
            $app['paginator.options'] = array_replace([
                'offset_page'    => 2,
                'page_param'     => 'page',
                'items_per_page' => 10,
                'hide_prev_next' => true,
                    ], $app['paginator.options']);

            return new \Pagination\Util\Paginator($app);

$app is of type array<string,array<string,integer|string|boolean>,{"paginator.options":"array<string,integer|string|boolean>"}>, but the function expects a object<Silex\Application>.

        });

        if (!$app->offsetExists('twig')) {
            $app->register(new \Silex\Provider\TwigServiceProvider());
        }

        if (!$app->offsetExists('translator')) {
            $app->register(new \Silex\Provider\TranslationServiceProvider());
        }

        $app['twig'] = $app->extend('twig', function (\Twig_Environment $twig) {
            $twig->addExtension(new Twig\TwigExtension());

            return $twig;
        });

        if (isset($app['twig.path']) && !is_array($app['twig.path'])) {
            $app['twig.path'] = [$app['twig.path']];
        }
        
        $app['twig.path'] = array_merge_recursive($app['twig.path'], [
            __DIR__.DIRECTORY_SEPARATOR.'Resources'.DIRECTORY_SEPARATOR.'views',
        ]);

        $app['translator'] = $app->extend('translator', function (Translator $translator, Application $app) {

The parameter $app is not used and could be removed.

            $translationDirectory = __DIR__.DIRECTORY_SEPARATOR.'Resources'.DIRECTORY_SEPARATOR.'translations';
            $translator->addResource('yaml', $translationDirectory.DIRECTORY_SEPARATOR.'messages.bg.yml', 'bg');
            $translator->addResource('yaml', $translationDirectory.DIRECTORY_SEPARATOR.'messages.en.yml', 'en');

            return $translator;
        });
    }
}