SimpleRepoFacade::fetchAllMilestones() - Code Metrics - Inspection of "Merge pull request #1 from msvrtan/initial" - devboard/github-object-api-facade - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 12f683...a4b1f6 )

by Miro

created 2016-02-13 16:44 UTC

SimpleRepoFacade::fetchAllMilestones() A

↳ Parent: SimpleRepoFacade

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	11
rs	9.4285
cc	2
eloc	6
nc	2
nop	0

<?php
namespace DevBoardLib\GithubObjectApiFacade\Repo;

use DevBoardLib\GithubApiFacade\Repo\RepoFacade;
use DevBoardLib\GithubObjectApiFacade\Repo\Issue\Converter\GithubIssueConverter;
use DevBoardLib\GithubObjectApiFacade\Repo\Milestone\Converter\GithubMilestoneConverter;

class SimpleRepoFacade implements ObjectRepoFacade
{
    private $repoFacade;
    private $githubIssueConverter;
    private $githubMilestoneConverter;

    /**
     * SimpleRepoFacade constructor.
     *
     * @param $repoFacade
     */
    public function __construct(
        RepoFacade $repoFacade,
        GithubIssueConverter $githubIssueConverter,
        GithubMilestoneConverter $githubMilestoneConverter
    ) {
        $this->repoFacade               = $repoFacade;
        $this->githubIssueConverter     = $githubIssueConverter;
        $this->githubMilestoneConverter = $githubMilestoneConverter;
    }

    public function fetchAllMilestones()
    {
        $results    = [];
        $rawResults = $this->repoFacade->fetchAllMilestones();

        foreach ($rawResults as $rawResult) {
            $results[] = $this->githubMilestoneConverter->convert($rawResult);
        }

        return $results;
    }

    public function fetchAllIssues()
    {
        $results    = [];
        $rawResults = $this->repoFacade->fetchAllIssues();

        foreach ($rawResults as $rawResult) {
            $results[] = $this->githubIssueConverter->convert($rawResult);
        }

        return $results;
    }
}


1			<?php
2			namespace DevBoardLib\GithubObjectApiFacade\Repo;
3
4			use DevBoardLib\GithubApiFacade\Repo\RepoFacade;
5			use DevBoardLib\GithubObjectApiFacade\Repo\Issue\Converter\GithubIssueConverter;
6			use DevBoardLib\GithubObjectApiFacade\Repo\Milestone\Converter\GithubMilestoneConverter;
7
8			class SimpleRepoFacade implements ObjectRepoFacade
9			{
10			private $repoFacade;
11			private $githubIssueConverter;
12			private $githubMilestoneConverter;
13
14			/**
15			* SimpleRepoFacade constructor.
16			*
17			* @param $repoFacade
18			*/
19			public function __construct(
20			RepoFacade $repoFacade,
21			GithubIssueConverter $githubIssueConverter,
22			GithubMilestoneConverter $githubMilestoneConverter
23			) {
24			$this->repoFacade = $repoFacade;
25			$this->githubIssueConverter = $githubIssueConverter;
26			$this->githubMilestoneConverter = $githubMilestoneConverter;
27			}
28
29			public function fetchAllMilestones()
30			{
31			$results = [];
32			$rawResults = $this->repoFacade->fetchAllMilestones();
33
34			foreach ($rawResults as $rawResult) {
35			$results[] = $this->githubMilestoneConverter->convert($rawResult);
36			}
37
38			return $results;
39			}
40
41			public function fetchAllIssues()
42			{
43			$results = [];
44			$rawResults = $this->repoFacade->fetchAllIssues();
45
46			foreach ($rawResults as $rawResult) {
47			$results[] = $this->githubIssueConverter->convert($rawResult);
48			}
49
50			return $results;
51			}
52			}
53

devboard / github-object-api-facade

Push — master ( 12f683...a4b1f6 )

SimpleRepoFacade::fetchAllMilestones() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like