GithubMilestoneConvertTrait - Code Metrics - devboard/github-object-api-facade - Measure and Improve Code Quality continuously with Scrutinizer

GithubMilestoneConvertTrait A
last analyzed 2016-05-22 16:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	45
Duplicated Lines	46.67 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
wmc	3
c	3
b	0
f	2
lcom	1
cbo	3
dl	21
loc	45
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	convertMilestone()	21	21	1
A	getMilestoneIfExists()	0	8	2

How to fix Duplicated Code

<?php

namespace DevBoardLib\GithubObjectApiFacade\Repo\Milestone\Converter;

use DateTime;
use DevBoardLib\GithubCore\Milestone\GithubMilestoneId;
use DevBoardLib\GithubCore\Milestone\GithubMilestoneSource;
use DevBoardLib\GithubCore\Milestone\State\GithubMilestoneStateFactory;

/**
 * Class GithubMilestoneConvertTrait.
 */
trait GithubMilestoneConvertTrait
{
    /**
     * @param array $data
     *
     * @throws \Exception
     *
     * @return GithubMilestoneSource
     */
    protected function convertMilestone(array $data)

    {
        $milestone = new GithubMilestoneSource(
            new GithubMilestoneId($data['id']),
            $this->githubRepo,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $data['number'],
            GithubMilestoneStateFactory::create($data['state']),
            $data['title'],
            $data['description'],
            $this->getUserIfExists($data['creator']),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $data['open_issues'],
            $data['closed_issues'],
            $this->getDateIfExists($data['due_on']),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            new DateTime($data['created_at']),
            new DateTime($data['updated_at']),
            $this->getDateIfExists($data['closed_at'])
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        );

        return $milestone;
    }

    /**
     * @param array|null $data
     *
     * @return GithubMilestoneSource|null
     */
    protected function getMilestoneIfExists(array $data = null)
    {
        if (empty($data)) {
            return null;
        }

        return $this->convertMilestone($data);
    }
}


1		<?php
2
3		namespace DevBoardLib\GithubObjectApiFacade\Repo\Milestone\Converter;
4
5		use DateTime;
6		use DevBoardLib\GithubCore\Milestone\GithubMilestoneId;
7		use DevBoardLib\GithubCore\Milestone\GithubMilestoneSource;
8		use DevBoardLib\GithubCore\Milestone\State\GithubMilestoneStateFactory;
9
10		/**
11		* Class GithubMilestoneConvertTrait.
12		*/
13		trait GithubMilestoneConvertTrait
14		{
15		/**
16		* @param array $data
17		*
18		* @throws \Exception
19		*
20		* @return GithubMilestoneSource
21		*/
22	View Code Duplication	protected function convertMilestone(array $data)
		0 ignored issues – show Duplication introduced 2016-02-13 15:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$milestone = new GithubMilestoneSource(
25		new GithubMilestoneId($data['id']),
26		$this->githubRepo,
		0 ignored issues – show Bug introduced 2016-02-13 15:37 UTC by Report Bug Copy Issue Report The property `githubRepo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27		$data['number'],
28		GithubMilestoneStateFactory::create($data['state']),
29		$data['title'],
30		$data['description'],
31		$this->getUserIfExists($data['creator']),
		0 ignored issues – show Bug introduced 2016-02-19 14:38 UTC by Report Bug Copy Issue Report It seems like `getUserIfExists()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32		$data['open_issues'],
33		$data['closed_issues'],
34		$this->getDateIfExists($data['due_on']),
		0 ignored issues – show Bug introduced 2016-02-13 15:37 UTC by Report Bug Copy Issue Report It seems like `getDateIfExists()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35		new DateTime($data['created_at']),
36		new DateTime($data['updated_at']),
37		$this->getDateIfExists($data['closed_at'])
		0 ignored issues – show Bug introduced 2016-02-13 15:37 UTC by Report Bug Copy Issue Report It seems like `getDateIfExists()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38
39		);
40
41		return $milestone;
42		}
43
44		/**
45		* @param array\|null $data
46		*
47		* @return GithubMilestoneSource\|null
48		*/
49		protected function getMilestoneIfExists(array $data = null)
50		{
51		if (empty($data)) {
52		return null;
53		}
54
55		return $this->convertMilestone($data);
56		}
57		}
58

devboard / github-object-api-facade

GithubMilestoneConvertTrait A last analyzed 2016-05-22 16:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

GithubMilestoneConvertTrait A
last analyzed 2016-05-22 16:42 UTC