GithubBranchConvertTrait - Code Metrics - devboard/github-object-api-facade - Measure and Improve Code Quality continuously with Scrutinizer

GithubBranchConvertTrait A
last analyzed 2016-05-22 16:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
wmc	1
c	3
b	0
f	1
lcom	1
cbo	1
dl	0
loc	17
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	convertBranch()	0	9	1

<?php

namespace DevBoardLib\GithubObjectApiFacade\Repo\Branch\Converter;

use DevBoardLib\GithubCore\Branch\GithubBranchSource;

/**
 * Class GithubBranchConvertTrait.
 */
trait GithubBranchConvertTrait
{
    /**
     * @param array $data
     *
     * @return GithubBranchSource
     */
    protected function convertBranch(array $data)
    {
        return new GithubBranchSource(
            $this->githubRepo->getId(),
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $data['name'],
            $this->convertCommit($data['commit'])
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        );
    }
}


1			<?php
2
3			namespace DevBoardLib\GithubObjectApiFacade\Repo\Branch\Converter;
4
5			use DevBoardLib\GithubCore\Branch\GithubBranchSource;
6
7			/**
8			* Class GithubBranchConvertTrait.
9			*/
10			trait GithubBranchConvertTrait
11			{
12			/**
13			* @param array $data
14			*
15			* @return GithubBranchSource
16			*/
17			protected function convertBranch(array $data)
18			{
19			return new GithubBranchSource(
20			$this->githubRepo->getId(),
			0 ignored issues – show Bug introduced 2016-02-22 19:43 UTC by Report Bug Copy Issue Report The property `githubRepo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21			$data['name'],
22			$this->convertCommit($data['commit'])
			0 ignored issues – show Bug introduced 2016-02-22 19:43 UTC by Report Bug Copy Issue Report It seems like `convertCommit()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23
24			);
25			}
26			}
27

devboard / github-object-api-facade

GithubBranchConvertTrait A last analyzed 2016-05-22 16:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

GithubBranchConvertTrait A
last analyzed 2016-05-22 16:42 UTC