Connection::close() - Code Metrics - Inspection of "Initial version after creating desired base struct..." - devTransition/yii2-rabbitmq - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 7ec6a7...e72b38 )

by Nicolas

created 2016-01-28 23:29 UTC

Connection::close() A

↳ Parent: Connection

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace devtransition\rabbitmq\base;

use PhpAmqpLib\Channel\AMQPChannel;
use PhpAmqpLib\Connection\AMQPStreamConnection;
use PhpAmqpLib\Connection\AMQPSSLConnection;
use yii\base\Component;


/**
 * Connection represents an advanced instance of PhpAmqpLibs AMQPStreamConnection.
 *
 * Connection works together with Channels .... explain..
 *
 * @property string $host RabbitMQ server hostname or IP address. Defaults to `localhost`.
 * @property integer $port TCP-Port where RabbitMQ is listening. Defaults to `5672`.
 * @property string $username RabbitMQ server username on connect. Defaults to `guest`.
 * @property string $password RabbitMQ server password on connect. Defaults to `guest`.
 * @property string $vhost RabbitMQ server virtual host to use. Defaults to `/`.
 * @property \PhpAmqpLib\Connection\AMQPStreamConnection $connection The PhpAmqpLib connection instance. This property is read-only.
 *
 * @author Nicolas Wild <[email protected]>
 */
class Connection extends Component implements ConnectionInterface
{
    /**
     * @var AMQPStreamConnection
     */
    public $connection;
    /**
     * @var string
     */
    public $host = 'localhost';
    /**
     * @var integer
     */
    public $port = 5672;
    /**
     * @var string
     */
    public $username = 'guest';
    /**
     * @var string
     */
    public $password = '';
    /**
     * @var string
     */
    public $vhost = '/';
    /**
     * @var array
     */
    public $options = [];
    /**
     * @var AMQPChannel[]
     */
    protected $channels = [];

    /**
     * @var AMQPStreamConnection
     */
    protected $amqpConnection;
    /**
     * @inheritdoc
     */
    public function init()
    {
        parent::init();
        $this->_parseOptions();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->open();
    }

    public function open()
    {
        /* TODO: Implement options appy and TLS */

        $this->amqpConnection = new AMQPStreamConnection(
            $this->host,
            $this->port,
            $this->username,
            $this->password,
            $this->vhost,
            $insist = false,
            $login_method = 'AMQPLAIN',
            $login_response = null,
            $locale = 'en_US',
            $connection_timeout = 3,
            $read_write_timeout = 3,
            $context = null,
            $keepalive = false,
            $heartbeat = 0
        );
    }

    public function close()
    {
        $this->amqpConnection->close();
    }

    public function reconnect()
    {
        $this->amqpConnection-> reconnect();
    }

    public function isConnected()
    {
        $this->amqpConnection->isConnected();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

    /**
     * Returns low-level AMQP connection instance
     *
     * @return AMQPStreamConnection|AMQPSSLConnection
     */
    public function getAmqpInstance()
    {
        return $this->amqpConnection;
    }


    private function _parseOptions()
    {
        /* TODO: Implement */
    }
}


1			<?php
2
3			namespace devtransition\rabbitmq\base;
4
5			use PhpAmqpLib\Channel\AMQPChannel;
6			use PhpAmqpLib\Connection\AMQPStreamConnection;
7			use PhpAmqpLib\Connection\AMQPSSLConnection;
8			use yii\base\Component;
9
10
11			/**
12			* Connection represents an advanced instance of PhpAmqpLibs AMQPStreamConnection.
13			*
14			* Connection works together with Channels .... explain..
15			*
16			* @property string $host RabbitMQ server hostname or IP address. Defaults to `localhost`.
17			* @property integer $port TCP-Port where RabbitMQ is listening. Defaults to `5672`.
18			* @property string $username RabbitMQ server username on connect. Defaults to `guest`.
19			* @property string $password RabbitMQ server password on connect. Defaults to `guest`.
20			* @property string $vhost RabbitMQ server virtual host to use. Defaults to `/`.
21			* @property \PhpAmqpLib\Connection\AMQPStreamConnection $connection The PhpAmqpLib connection instance. This property is read-only.
22			*
23			* @author Nicolas Wild <[email protected]>
24			*/
25			class Connection extends Component implements ConnectionInterface
26			{
27			/**
28			* @var AMQPStreamConnection
29			*/
30			public $connection;
31			/**
32			* @var string
33			*/
34			public $host = 'localhost';
35			/**
36			* @var integer
37			*/
38			public $port = 5672;
39			/**
40			* @var string
41			*/
42			public $username = 'guest';
43			/**
44			* @var string
45			*/
46			public $password = '';
47			/**
48			* @var string
49			*/
50			public $vhost = '/';
51			/**
52			* @var array
53			*/
54			public $options = [];
55			/**
56			* @var AMQPChannel[]
57			*/
58			protected $channels = [];
59
60			/**
61			* @var AMQPStreamConnection
62			*/
63			protected $amqpConnection;
64			/**
65			* @inheritdoc
66			*/
67			public function init()
68			{
69			parent::init();
70			$this->_parseOptions();
			0 ignored issues – show Unused Code introduced 2016-01-28 23:40 UTC by Report Bug Copy Issue Report The call to the method `devtransition\rabbitmq\b...ection::_parseOptions()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
71			$this->open();
72			}
73
74			public function open()
75			{
76			/* TODO: Implement options appy and TLS */
77
78			$this->amqpConnection = new AMQPStreamConnection(
79			$this->host,
80			$this->port,
81			$this->username,
82			$this->password,
83			$this->vhost,
84			$insist = false,
85			$login_method = 'AMQPLAIN',
86			$login_response = null,
87			$locale = 'en_US',
88			$connection_timeout = 3,
89			$read_write_timeout = 3,
90			$context = null,
91			$keepalive = false,
92			$heartbeat = 0
93			);
94			}
95
96			public function close()
97			{
98			$this->amqpConnection->close();
99			}
100
101			public function reconnect()
102			{
103			$this->amqpConnection-> reconnect();
104			}
105
106			public function isConnected()
107			{
108			$this->amqpConnection->isConnected();
			0 ignored issues – show Unused Code introduced 2016-01-28 23:40 UTC by Report Bug Copy Issue Report The call to the method `PhpAmqpLib\Connection\AM...nnection::isConnected()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
109			}
110
111			/**
112			* Returns low-level AMQP connection instance
113			*
114			* @return AMQPStreamConnection\|AMQPSSLConnection
115			*/
116			public function getAmqpInstance()
117			{
118			return $this->amqpConnection;
119			}
120
121
122			private function _parseOptions()
123			{
124			/* TODO: Implement */
125			}
126			}
127

devTransition / yii2-rabbitmq

Push — develop ( 7ec6a7...e72b38 )

Connection::close() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like