Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class DocBlock |
||
9 | { |
||
10 | |||
11 | private $_reflector; |
||
12 | |||
13 | const ALLOWED_CLASS_OPTIONS = [ |
||
14 | 'timeout', |
||
15 | 'prio', |
||
16 | ]; |
||
17 | |||
18 | const ALLOWED_METHOD_OPTIONS = [ |
||
19 | 'timeout', |
||
20 | 'prio', |
||
21 | ]; |
||
22 | |||
23 | /** |
||
24 | * @param $class |
||
25 | */ |
||
26 | public function __construct(&$class) |
||
31 | |||
32 | View Code Duplication | public function getClassOptions() |
|
48 | |||
49 | View Code Duplication | public function getMethodOptions($method) |
|
65 | |||
66 | } |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: