dev-think-one / nova-thinkit

src/FeatureImage/Nova/HasFeatureImage.php

<?php

namespace NovaThinKit\FeatureImage\Nova;

use Illuminate\Http\Request;
use Laravel\Nova\Fields\Image;
use NovaThinKit\FeatureImage\Models\WithFeatureImage;

trait HasFeatureImage
{
    public function fieldFeatureImage(string $title = 'Feature Image', ?string $tag = null): Image
    {
        $model = $this->model();

It seems like model() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $attr = method_exists($model, 'featureImageKey') ? $model->featureImageKey($tag) : 'image';

        return Image::make($title, $attr)
            ->rules(['mimes:jpeg,png', 'max:' . 1024 * 10])
            ->deletable(true)
            ->store(function (Request $request, WithFeatureImage $model, string $attribute) use ($tag) {
                return function () use ($request, $model, $attribute, $tag) {
                    if ($request->hasFile($attribute)) {
                        $model->$attribute = $model
                            ->featureImageManager($tag)
                            ->storeUploaded($request->file($attribute));

It seems like $request->file($attribute) can also be of type Illuminate\Http\UploadedFile[] and array and null; however, parameter $image of NovaThinKit\FeatureImage\ImageManager::storeUploaded() does only seem to accept Illuminate\Http\UploadedFile, maybe add an additional type check?

                        $model->save();

The method save() does not exist on NovaThinKit\FeatureImage\Models\WithFeatureImage. It seems like you code against a sub-type of said class. However, the method does not exist in NovaThinKit\Tests\Fixtures\AdvertisingDTO. Are you sure you never get one of those?

                    }
                };
            })
            ->delete(function (Request $request, WithFeatureImage $model) use ($attr, $tag) {
                if ($model->featureImageManager($tag)->delete()) {
                    $model->$attr = null;
                }

                return true;
            })
            ->preview(function ($value, $disk, WithFeatureImage $model) use ($tag) {
                return $model->featureImageManager($tag)->url('thumb');
            })
            ->thumbnail(function ($value, $disk, WithFeatureImage $model) use ($tag) {
                return $model->featureImageManager($tag)->url('thumb');
            })
            ->download(function ($request, $model, $disk, $path) use ($tag) {

The parameter $path is not used and could be removed.

The parameter $disk is not used and could be removed.

                return $model->featureImageManager($tag)->download();
            })
            ->help('Image: jpg or png, ~1600x1200px. The script will automatically crop images');
    }
}