dev-think-one / nova-thinkit

src/FeatureImage/Models/HasFeatureImage.php

<?php


namespace NovaThinKit\FeatureImage\Models;

use Illuminate\Support\Str;
use NovaThinKit\FeatureImage\FeatureImageManager;
use NovaThinKit\FeatureImage\ImageManager;

trait HasFeatureImage
{
    protected ?ImageManager $featureImageManager = null;

    protected function createFeatureImageManager(?string $tag = null): ImageManager

The parameter $tag is not used and could be removed.

    {
        if (!$this->featureImageManager) {
            $featureImageManagerConfig = property_exists($this, 'featureImageManagerConfig') ? $this->featureImageManagerConfig : 'nova-thinkit.feature-images.default';
            $this->featureImageManager = FeatureImageManager::fromConfig(config($featureImageManagerConfig));
        }

        return $this->featureImageManager;
    }

    public function featureImageManager(?string $tag = null): ImageManager
    {
        return $this->createFeatureImageManager($tag)
            ->setTag($tag)

The method setTag() does not exist on NovaThinKit\FeatureImage\ImageManager. Since it exists in all sub-types, consider adding an abstract or default implementation to NovaThinKit\FeatureImage\ImageManager.

            ->setModel($this);
    }


    public function featureImageManagerDirectory(?string $tag = null): string

The parameter $tag is not used and could be removed.

    {
        $class = $this->getMorphClass();

It seems like getMorphClass() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $path = Str::contains($class, '\\') ? class_basename($class) : $class;

        return base64_encode($path . '-' . $this->getKey());

It seems like getKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function featureImageKey(?string $tag = null): string
    {
        return $tag ?: 'image';
    }
}