dev-think-one /
nova-list-card
| Conditions | 6 |
| Paths | 2 |
| Total Lines | 55 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 41 |
| CRAP Score | 6 |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 20 | 4 | public function __invoke(CardRequest $cardRequest) |
|
| 21 | { |
||
| 22 | |||
| 23 | 4 | $callback = function () use ($cardRequest) { |
|
| 24 | try { |
||
| 25 | 4 | $resource = $cardRequest->cardResource(); |
|
|
Unused Code
introduced
by
|
|||
| 26 | 1 | } catch (\Exception $e) { |
|
| 27 | 1 | return Response::json([ |
|
| 28 | 1 | 'message' => $e->getMessage(), |
|
| 29 | 1 | ], 404); |
|
| 30 | } |
||
| 31 | |||
| 32 | 3 | return $cardRequest->cardResource()::indexQuery( |
|
| 33 | 3 | $cardRequest, |
|
| 34 | 3 | $cardRequest->prepareQuery() |
|
| 35 | 3 | ) |
|
| 36 | 3 | ->get() |
|
| 37 | 3 | ->mapInto($cardRequest->cardResource()) |
|
| 38 | 3 | ->filter(function ($resource) use ($cardRequest) { |
|
| 39 | 3 | return $resource->authorizedToView($cardRequest); |
|
| 40 | 3 | }) |
|
| 41 | 3 | ->map(callback: function ($resource) use ($cardRequest) { |
|
| 42 | 3 | $data = [ |
|
| 43 | 3 | 'title' => $resource->title(), |
|
| 44 | 3 | 'url' => route('nova.pages.detail', [$resource::uriKey(), $resource->getKey()]), |
|
| 45 | 3 | ]; |
|
| 46 | |||
| 47 | 3 | $card = $cardRequest->card(); |
|
| 48 | |||
| 49 | 3 | if ($card->valueColumn) { |
|
| 50 | 3 | $value = $resource->resource->{$card->valueColumn}; |
|
| 51 | 3 | $data['value'] = match ($card->valueFormatter) { |
|
| 52 | 3 | 'datetime' => Carbon::parse($value)->format($card->valueFormat), |
|
| 53 | 3 | 'integer' => (int)$value, |
|
| 54 | 3 | default => $value, |
|
| 55 | 3 | }; |
|
| 56 | } |
||
| 57 | |||
| 58 | 3 | if ($card->timestampColumn) { |
|
| 59 | 1 | $data['timestamp'] = $resource->resource->{$card->timestampColumn}?->format($card->timestampFormat ?: 'Y-m-d'); |
|
| 60 | } |
||
| 61 | |||
| 62 | 3 | return $data; |
|
| 63 | 3 | }); |
|
| 64 | 4 | }; |
|
| 65 | |||
| 66 | 4 | if ($cacheFor = $cardRequest->card()?->cacheFor()) { |
|
| 67 | 1 | return Cache::remember( |
|
| 68 | 1 | $cardRequest->card()->getCacheKey($cardRequest), |
|
| 69 | 1 | $cacheFor, |
|
| 70 | 1 | $callback |
|
| 71 | 1 | ); |
|
| 72 | } |
||
| 73 | |||
| 74 | 3 | return call_user_func($callback); |
|
| 75 | } |
||
| 77 |
Loading history...