dev-think-one / nova-flexible-content

src/Nova/Fields/FlexibleUpdatingAttribute.php

<?php

namespace NovaFlexibleContent\Nova\Fields;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Storage;
use Laravel\Nova\Fields\Field;
use Laravel\Nova\Http\Requests\NovaRequest;
use NovaFlexibleContent\Flexible;
use NovaFlexibleContent\Http\FlexibleAttribute;

trait FlexibleUpdatingAttribute
{

    protected function defaultPreviewCallback(): \Closure
    {
        return function ($value, ?string $disk, $model) {

The parameter $model is not used and could be removed.

            return $value ? Storage::disk($disk)->url($value) : null;
        };
    }

    protected function defaultDownloadCallback(): \Closure
    {
        return function (NovaRequest $request, Model $model, ?string $disk, $value) {
            return $value ? Storage::disk($disk)->download($value) : null;
        };
    }

    protected function defaultDeleteCallback(): \Closure
    {
        return function (NovaRequest $request, $model, ?string $disk, $value) {
            if ($model instanceof Model) {
                $this->flexibleSetAttribute($request, $model, null);

                if ($request->isMethod('DELETE')) {
                    // Prevent trafficCop error.
                    $model->timestamps = false;
                }
            }

            if ($value) {
                Storage::disk($disk)->delete($value);
            }

            return true;
        };
    }

    /**
     * Currently this is bad bad bad solution.
     * But currently need think about deadline.
     * TODO: refactor and find other clever solution.
     *
     * @param NovaRequest $request
     * @param Model       $model
     * @param mixed|null  $newValue
     * @return Model
     */
    protected function flexibleSetAttribute(NovaRequest $request, Model $model, mixed $newValue = null): Model
    {
        if (str_contains($request->route('field'), FlexibleAttribute::GROUP_SEPARATOR)) {

It seems like $request->route('field') can also be of type Illuminate\Routing\Route and null and object; however, parameter $haystack of str_contains() does only seem to accept string, maybe add an additional type check?

            [$groupKey, $fieldKey] = explode(FlexibleAttribute::GROUP_SEPARATOR, $request->field, 2);

            /** @var Flexible $field */
            $request->findResourceOrFail()
                    ->availableFields($request)
                    ->each(function (Field $field) use ($model, $groupKey, $fieldKey, $newValue) {
                        if ($field instanceof Flexible) {
                            /** @var Flexible $field */
                            $field->resolve($model);
                            if ($field->setAttributeRecursive($groupKey, $fieldKey, $newValue)) {
                                $field->reFillValue($model);

                                // Break loop
                                return false;
                            }
                        }
                    });
        }

        return $model;
    }
}