dev-think-one / nova-flexible-content

src/Layouts/LayoutTraits/HasFieldsRules.php

<?php

namespace NovaFlexibleContent\Layouts\LayoutTraits;

use Illuminate\Support\Str;
use Laravel\Nova\Fields\Field;
use NovaFlexibleContent\Http\FlexibleAttribute;
use NovaFlexibleContent\Http\ScopedRequest;

trait HasFieldsRules
{
    /**
     * Get validation rules for fields concerned by given request.
     */
    public function generateRules(ScopedRequest $request, string $key, ?string $type = null): array
    {
        return $this->fieldsCollection()->map(fn ($field) => $this->getScopedFieldRules($field, $request, $key, $type))

It seems like fieldsCollection() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ->collapse()
            ->all();
    }

    /**
     * Get validation rules for fields concerned by given request.
     */
    protected function getScopedFieldRules(Field $field, ScopedRequest $request, string $key, ?string $type = null): array
    {
        $type   = Str::ucfirst($type);
        $method = "get{$type}Rules";

        $rules = [];
        if(method_exists($field, $method)) {
            $rules = call_user_func([$field, $method], $request);
        }

        return collect($rules)

It seems like $rules can also be of type array; however, parameter $value of collect() does only seem to accept Illuminate\Contracts\Support\Arrayable, maybe add an additional type check?

            ->mapWithKeys(function ($validatorRules, $attribute) use ($key, $field, $request) {
                $key = $request->isFileAttribute($attribute)
                    ? $request->getFileAttribute($attribute)
                    : "{$key}.attributes.{$attribute}";

                return [$key => $this->wrapScopedFieldRules($field, $validatorRules)];
            })
            ->filter()
            ->all();
    }

    /**
     * Wrap the rules in an array containing field information for later use.
     */
    protected function wrapScopedFieldRules(Field $field, array $rules = []): array
    {
        if (is_a($rules['attribute'] ?? null, FlexibleAttribute::class)) {
            return $rules;
        }

        return [
            'attribute' => FlexibleAttribute::make($field->attribute, $this->inUseKey()),

It seems like inUseKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'rules'     => $rules,
        ];
    }
}