dev-think-one / laravel-myriad-data-store

src/Actions/DownloadMyriadIssues.php

<?php

namespace MyriadDataStore\Actions;

use Illuminate\Support\Carbon;
use Illuminate\Support\Str;
use MyriadDataStore\Models\MyriadIssue;
use MyriadSoap\Exceptions\UnexpectedTypeException;
use MyriadSoap\MyriadSoap;

class DownloadMyriadIssues
{
    use UsesCollectionFormat;

    public static ?array $collectionFormat = null;

    protected function defaultCollectionFormat(): array
    {
        return [
            'Issue_ID'        => fn ($i) => (int) tap($i, fn () => throw_if(!is_numeric($i), UnexpectedTypeException::class)),
            'Title_ID'        => fn ($i) => (int) tap($i, fn () => throw_if(!is_numeric($i), UnexpectedTypeException::class)),
            'Issue'           => fn ($i) => (string) $i,
            'IssueNumber'     => fn ($i) => (int) tap($i, fn () => throw_if(!is_numeric($i), UnexpectedTypeException::class)),
            'PublicationDate' => fn ($i) => Carbon::createFromFormat('Y-m-d', $i),
        ];
    }

    public function execute(?int $titleId = null): int
    {
        if ($titleId) {

The expression $titleId of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $formattedCollection = MyriadSoap::SOAP_getIssuesForTitle_Collection(['Title_ID' => $titleId], $this->collectionFormat(), 'Issue');
        } else {
            $formattedCollection = MyriadSoap::SOAP_getIssues_Collection([], $this->collectionFormat());
        }

        $count = 0;
        foreach ($formattedCollection as $item) {
            $myriadModel = MyriadIssue::find($item['Issue_ID']);
            if (!$myriadModel) {
                $myriadModel     = new MyriadIssue;
                $myriadModel->id = $item['Issue_ID'];
            }
            $myriadModel->name             = Str::limit($item['Issue'], 252);

The property name does not seem to exist on MyriadDataStore\Models\MyriadIssue. Are you sure there is no database migration missing?

            $myriadModel->title_id         = $item['Title_ID'];

The property title_id does not exist on MyriadDataStore\Models\MyriadIssue. Did you mean title?

            $myriadModel->number           = $item['IssueNumber'];

The property number does not seem to exist on MyriadDataStore\Models\MyriadIssue. Are you sure there is no database migration missing?

            $myriadModel->publication_date = $item['PublicationDate'];

The property publication_date does not seem to exist on MyriadDataStore\Models\MyriadIssue. Are you sure there is no database migration missing?

            $myriadModel->save();
            $count++;
        }

        return $count;
    }
}