dev-think-one / laravel-json-field-cast

src/Json/HasNumericAttributes.php

<?php

namespace JsonFieldCast\Json;

trait HasNumericAttributes
{
    public function increment(string $key, int|float $amount = 1): static
    {
        $value = $this->getAttribute($key);

It seems like getAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($value && !is_numeric($value)) {
            throw new \InvalidArgumentException("Value of key [{$key}] is not numeric");
        }

        if (!$value) {
            $value = 0;
        }

        return $this->setAttribute($key, $value + $amount);

It seems like setAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function decrement(string $key, int|float $amount = 1): static
    {
        $value = $this->getAttribute($key);

        if ($value && !is_numeric($value)) {
            throw new \InvalidArgumentException("Value of key [{$key}] is not numeric");
        }

        if (!$value) {
            $value = 0;
        }

        return $this->setAttribute($key, $value - $amount);
    }
}