Efabrica\TranslationsAutomatization\Command\CheckTranslations\CheckTranslationsCommand::execute()

Complexity

Conditions	18
Paths	9

Size

Total Lines	84
Code Lines	62

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	3

<?php
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if (!is_file($input->getArgument('config'))) {
            throw new InvalidArgumentException('File "' . $input->getArgument('config') . '" does not exist');
        }
        parse_str($input->getOption('params'), $params);
        extract($params);

        $checkDictionariesConfig = require $input->getArgument('config');
        if ($checkDictionariesConfig instanceof InvalidConfigInstanceReturnedException) {
            throw $checkDictionariesConfig;
        }
        if (!$checkDictionariesConfig instanceof CheckDictionariesConfig) {
            throw new InvalidConfigInstanceReturnedException('"' . (is_object($checkDictionariesConfig) ? get_class($checkDictionariesConfig) : $checkDictionariesConfig) . '" is not instance of ' . CheckDictionariesConfig::class);
        }

        $output->writeln('');
        $output->writeln('Loading dictionaries...');

        $dictionaries = $checkDictionariesConfig->load();
        $onlyOneLang = (count($dictionaries) === 1);
        $errors = [];
        $dirs = ['./app', './src'];

        $exclude = json_decode($input->getOption('exclude') ?? '', true) ?? [];
        $include = json_decode($input->getOption('include') ?? '', true) ?? [];
        $this->processTranslationFindConfig($exclude, $include);
        $results = (new CodeAnalyzer($dirs, $this->translationFindConfig))->analyzeDirectories();
        foreach ($results as $call) {
            $key = $call['key'];
            if ($key === 'dynamic_value' || !is_string($key)) {
                continue;
            }
            if ($dictionaries === []) {
                $errors[] = 'No dictionaries found.';
                break;
            }
            foreach ($dictionaries as $lang => $dictionary) {
                $langText = !$onlyOneLang ? ' for language "' . $lang . '"' : '';
                if (!isset($dictionary[$key])) {
                    $errors[] = sprintf(
                        'Missing translation for key "%s" ' . $langText . 'in file: %s:%s call: "%s"',
                        $key,
                        $call['file'],
                        $call['line'],
                        $call['call']
                    );
                } else {
                    // find plural bad key
                    $dictionaryTranslate = $dictionary[$key];
                    $pluralKey = $call['arg'] ?? null;
                    $pluralKeyInFile = $pluralKey ? '%' . $pluralKey . '%' : null;
                    if ($pluralKey && strpos($dictionaryTranslate, $pluralKeyInFile) === false) {

It seems like $pluralKeyInFile can also be of type null; however, parameter $needle of strpos() does only seem to accept string, maybe add an additional type check?

                        $errors[] = sprintf(
                            'Translation key "%s" ' . $langText . 'in file: %s:%s call: "%s" has bad plural key: %s for translation: "%s"',
                            $key,
                            $call['file'],
                            $call['line'],
                            $call['call'],
                            $pluralKeyInFile,
                            $dictionaryTranslate
                        );
                    }
                    if ($pluralKey === null && preg_match('/.*%.+%.*/', $dictionaryTranslate) === false) {
                        $errors[] = sprintf(
                            'Translation key "%s" ' . $langText . 'in file: %s:%s call: "%s" has missing plural key for translation: "%s"',
                            $key,
                            $call['file'],
                            $call['line'],
                            $call['call'],
                            $dictionaryTranslate
                        );
                    }
                }
            }
        }
        $output->writeln('', OutputInterface::VERBOSITY_VERY_VERBOSE);
        foreach (array_unique($errors) as $error) {
            $output->writeln($error, OutputInterface::VERBOSITY_VERY_VERBOSE);
        }

        $output->writeln('');
        $output->writeln('<comment>' . count($errors) . ' errors found</comment>');
        return count($errors);
    }