Issues in Firewall.php (master) - Issues in master - desarrolla2/kata1 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Component/Firewall/Firewall.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the "Kata 1" package.
 *
 * Copyright (c) Daniel González
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Daniel González <[email protected]>
 */

namespace Component\Firewall;

/**
 * Firewall.
 */
class Firewall
{
    const ROLE_ADMIN = 'ROLE_ADMIN';

    /**
     * @var array
     */
    protected $routes = [];

    /**
     * @param string|array $methods
     * @param string       $path
     * @param string       $role
     */
    public function addRoute($methods, $path, $role)
    {
        $this->routes[strtolower($path)] = [
            'path' => strtolower($path),
            'role' => $role,
            'methods' => is_array($methods) ? $methods : [$methods],
        ];
    }

    /**
     * @param string                 $method
     * @param string                 $uri
     * @param HasRolesInterface|null $user
     *
     * @return bool
     */
    public function isGranted($method, $uri, HasRolesInterface $user = null)
    {
        foreach ($this->getRoutes() as $route) {
            if ($this->isUriInRoutes($method, $uri, $route)) {
                if (!$this->isGrantedRoute($method, $uri, $route, $user)) {
                    return false;
                }
            }
        }

        return true;
    }

    /**
     * @param string                 $method
     * @param string                 $path
     * @param array                  $route
     * @param HasRolesInterface|null $user
     *
     * @return bool
     */
    protected function isGrantedRoute($method, $path, $route, HasRolesInterface $user = null)

    {
        if (!$user) {
            return false;
        }
        if ($this->hasRole($user, self::ROLE_ADMIN)) {
            return true;
        }
        if ($this->hasRole($user, $route['role'])) {
            return true;
        }

        return false;
    }

    /**
     * @param string $method
     * @param string $uri
     * @param string $route
     *
     * @return bool
     */
    protected function isUriInRoutes($method, $uri, $route)
    {
        if (substr(strtolower($uri), 0, strlen($route['path'])) != $route['path']) {
            return false;
        };
        if (!$route['methods']) {
            return true;
        }
        foreach ($route['methods'] as $routeMethod) {

            if ($routeMethod === $method) {
                return true;
            }
        }

        return false;
    }

    /**
     * @param HasRolesInterface $user
     * @param string            $role
     *
     * @return bool
     */
    protected function hasRole(HasRolesInterface $user, $role)
    {
        return in_array($role, $user->getRoles());
    }

    /**
     * @return array
     */
    protected function getRoutes()
    {
        return $this->routes;
    }
}


1		<?php
2
3		/*
4		* This file is part of the "Kata 1" package.
5		*
6		* Copyright (c) Daniel González
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*
11		* @author Daniel González <[email protected]>
12		*/
13
14		namespace Component\Firewall;
15
16		/**
17		* Firewall.
18		*/
19		class Firewall
20		{
21		const ROLE_ADMIN = 'ROLE_ADMIN';
22
23		/**
24		* @var array
25		*/
26		protected $routes = [];
27
28		/**
29		* @param string\|array $methods
30		* @param string $path
31		* @param string $role
32		*/
33	21	public function addRoute($methods, $path, $role)
34		{
35	21	$this->routes[strtolower($path)] = [
36	21	'path' => strtolower($path),
37	21	'role' => $role,
38	21	'methods' => is_array($methods) ? $methods : [$methods],
39		];
40	21	}
41
42		/**
43		* @param string $method
44		* @param string $uri
45		* @param HasRolesInterface\|null $user
46		*
47		* @return bool
48		*/
49	21	public function isGranted($method, $uri, HasRolesInterface $user = null)
50		{
51	21	foreach ($this->getRoutes() as $route) {
52	21	if ($this->isUriInRoutes($method, $uri, $route)) {
53	12	if (!$this->isGrantedRoute($method, $uri, $route, $user)) {
54	7	return false;
55		}
56	9	}
57	19	}
58
59	19	return true;
60		}
61
62		/**
63		* @param string $method
64		* @param string $path
65		* @param array $route
66		* @param HasRolesInterface\|null $user
67		*
68		* @return bool
69		*/
70	12	protected function isGrantedRoute($method, $path, $route, HasRolesInterface $user = null)
		0 ignored issues – show Unused Code introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$method` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$path` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
71		{
72	12	if (!$user) {
73	6	return false;
74		}
75	10	if ($this->hasRole($user, self::ROLE_ADMIN)) {
76	6	return true;
77		}
78	6	if ($this->hasRole($user, $route['role'])) {
79	4	return true;
80		}
81
82	2	return false;
83		}
84
85		/**
86		* @param string $method
87		* @param string $uri
88		* @param string $route
89		*
90		* @return bool
91		*/
92	21	protected function isUriInRoutes($method, $uri, $route)
93		{
94	21	if (substr(strtolower($uri), 0, strlen($route['path'])) != $route['path']) {
95	12	return false;
96		};
97	14	if (!$route['methods']) {
98	2	return true;
99		}
100	12	foreach ($route['methods'] as $routeMethod) {
		0 ignored issues – show Bug introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$route['methods']` of type `string` is not traversable. Loading history...
101	12	if ($routeMethod === $method) {
102	10	return true;
103		}
104	3	}
105
106	3	return false;
107		}
108
109		/**
110		* @param HasRolesInterface $user
111		* @param string $role
112		*
113		* @return bool
114		*/
115	10	protected function hasRole(HasRolesInterface $user, $role)
116		{
117	10	return in_array($role, $user->getRoles());
118		}
119
120		/**
121		* @return array
122		*/
123	21	protected function getRoutes()
124		{
125	21	return $this->routes;
126		}
127		}
128

desarrolla2 / kata1

Issues (19)

Security Analysis not enabled

src/Component/Firewall/Firewall.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like