ResponseHandler::negociate() - Code Metrics - desarrolla2/kata1 - Measure and Improve Code Quality continuously with Scrutinizer

ResponseHandler::negociate() A
last analyzed 2016-07-22 13:14 UTC

↳ Parent: ResponseHandler

Complexity

Conditions	3
Paths	4

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
ccs	8
cts	8
cp	1
rs	9.4285
cc	3
eloc	8
nc	4
nop	3
crap	3

<?php

/*
 * This file is part of the "Kata 1" package.
 *
 * Copyright (c) Daniel González
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Daniel González <[email protected]>
 */

namespace App\Negociation\Handler;

use Negotiation\Negotiator;



use Component\Http\JsonResponse;
use Component\Http\Request;
use Component\Http\Response;

/**
 * ResponseHandler.
 */
class ResponseHandler
{
    /**
     * @var Negotiator
     */
    protected $negotiator;

    /**
     * @param Negotiator $negotiator
     */
    public function __construct(Negotiator $negotiator)
    {
        $this->negotiator = $negotiator;
    }

    /**
     * @param Request $request
     * @param array   $data
     * @param int     $status
     *
     * @return Response
     */
    public function negociate(Request $request, array $data = [], $status = Response::HTTP_OK)
    {
        $acceptHeader = $request->getHeader('Accept') ? $request->getHeader('Accept') : 'application/json';
        $priorities = ['application/json', 'text/html; charset=UTF-8'];
        $mediaType = $this->negotiator->getBest($acceptHeader, $priorities);
        $value = $mediaType->getValue();
        if ($value == 'text/html; charset=UTF-8') {
            return new Response(print_r($data, true), $status);
        }

        return new JsonResponse($data, $status);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		/*
4		* This file is part of the "Kata 1" package.
5		*
6		* Copyright (c) Daniel González
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*
11		* @author Daniel González <[email protected]>
12		*/
13
14		namespace App\Negociation\Handler;
15
16		use Negotiation\Negotiator;
17
18
19
20		use Component\Http\JsonResponse;
21		use Component\Http\Request;
22		use Component\Http\Response;
23
24		/**
25		* ResponseHandler.
26		*/
27		class ResponseHandler
28		{
29		/**
30		* @var Negotiator
31		*/
32		protected $negotiator;
33
34		/**
35		* @param Negotiator $negotiator
36		*/
37	7	public function __construct(Negotiator $negotiator)
38		{
39	7	$this->negotiator = $negotiator;
40	7	}
41
42		/**
43		* @param Request $request
44		* @param array $data
45		* @param int $status
46		*
47		* @return Response
48		*/
49	7	public function negociate(Request $request, array $data = [], $status = Response::HTTP_OK)
50		{
51	7	$acceptHeader = $request->getHeader('Accept') ? $request->getHeader('Accept') : 'application/json';
52	7	$priorities = ['application/json', 'text/html; charset=UTF-8'];
53	7	$mediaType = $this->negotiator->getBest($acceptHeader, $priorities);
54	7	$value = $mediaType->getValue();
55	7	if ($value == 'text/html; charset=UTF-8') {
56	2	return new Response(print_r($data, true), $status);
57		}
58
59	5	return new JsonResponse($data, $status);
		0 ignored issues – show Documentation introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report `$data` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60		}
61		}
62

desarrolla2 / kata1

ResponseHandler::negociate() A last analyzed 2016-07-22 13:14 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ResponseHandler::negociate() A
last analyzed 2016-07-22 13:14 UTC