Request - Code Metrics - desarrolla2/kata1 - Measure and Improve Code Quality continuously with Scrutinizer

Request A
last analyzed 2016-07-22 13:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	148
Duplicated Lines	4.73 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

93.33%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	16
c	1
b	0
f	0
lcom	1
cbo	0
dl	7
loc	148
ccs	42
cts	45
cp	0.9333
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	23	3
A	createFromGlobals()	0	12	4
A	getMethod()	0	4	1
A	getUri()	0	4	1
A	get()	0	12	3
A	getHeader()	7	7	2
A	addHeader()	0	4	1
A	normalizeHeaderName()	0	4	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the "Kata 1" package.
 *
 * Copyright (c) Daniel González
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Daniel González <[email protected]>
 */

namespace Component\Http;

/**
 * Request.
 */
class Request
{
    /**
     * @var string
     */
    protected $method;

    /**
     * @var array
     */
    protected $get;

    /**
     * @var array
     */
    protected $post;

    /**
     * @var array
     */
    protected $server;

    /**
     * @var array
     */
    protected $cookie;

    /**
     * @var array
     */
    protected $headers;

    /**
     * @var string
     */
    protected $uri = '/';

    /**
     * @param string $method
     * @param array  $get
     * @param array  $post
     * @param array  $server
     * @param array  $cookie
     * @param array  $headers
     */
    public function __construct(
        $method,
        array $get = [],
        array $post = [],
        array $server = [],
        array $cookie = [],
        array $headers = []
    ) {
        $this->method = $method;
        $this->get = $get;
        $this->post = $post;
        $this->server = $server;
        $this->cookie = $cookie;
        foreach ($headers as $key => $value) {
            $this->addHeader($key, $value);
        }

        $path = $this->get('server', 'REQUEST_URI');
        $parsed = parse_url($path);
        if (isset($parsed['path'])) {
            $this->uri = $parsed['path'];
        }
    }

    public static function createFromGlobals()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $method = isset($_SERVER['REQUEST_METHOD']) ? $_SERVER['REQUEST_METHOD'] : 'GET';
        $headers = [];
        foreach ($_SERVER as $name => $value) {
            if (substr($name, 0, 5) == 'HTTP_') {
                $headers[str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', substr($name, 5)))))] = $value;
            }
        }

        return new static($method, $_GET, $_POST, $_SERVER, $_COOKIE, $headers);
    }

    /**
     * @return string
     */
    public function getMethod()
    {
        return $this->method;
    }

    /**
     * @return string
     */
    public function getUri()
    {
        return $this->uri;
    }

    /**
     * @param string $source
     * @param string $key
     * @param mixed  $default
     */
    public function get($source, $key, $default = false)
    {
        if (!in_array($source, ['get', 'post', 'server', 'cookie'])) {
            return;
        }
        $data = $this->$source;
        if (isset($data[$key])) {
            return $data[$key];
        }

        return $default;
    }

    /**
     * @param string $key
     *
     * @return string
     */
    public function getHeader($key)

    {
        $key = $this->normalizeHeaderName($key);
        if (isset($this->headers[$key])) {
            return $this->headers[$key];
        }
    }

    /**
     * @param string $key
     * @param string $value
     */
    public function addHeader($key, $value)
    {
        $this->headers[$this->normalizeHeaderName($key)] = $value;
    }

    /**
     * @param string $key
     *
     * @return string
     */
    protected function normalizeHeaderName($key)
    {
        return ucwords(str_replace('_', '-', strtolower($key)), '-');
    }
}


1			<?php
2
3			/*
4			* This file is part of the "Kata 1" package.
5			*
6			* Copyright (c) Daniel González
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*
11			* @author Daniel González <[email protected]>
12			*/
13
14			namespace Component\Http;
15
16			/**
17			* Request.
18			*/
19			class Request
20			{
21			/**
22			* @var string
23			*/
24			protected $method;
25
26			/**
27			* @var array
28			*/
29			protected $get;
30
31			/**
32			* @var array
33			*/
34			protected $post;
35
36			/**
37			* @var array
38			*/
39			protected $server;
40
41			/**
42			* @var array
43			*/
44			protected $cookie;
45
46			/**
47			* @var array
48			*/
49			protected $headers;
50
51			/**
52			* @var string
53			*/
54			protected $uri = '/';
55
56			/**
57			* @param string $method
58			* @param array $get
59			* @param array $post
60			* @param array $server
61			* @param array $cookie
62			* @param array $headers
63			*/
64	28		public function __construct(
65			$method,
66			array $get = [],
67			array $post = [],
68			array $server = [],
69			array $cookie = [],
70			array $headers = []
71			) {
72	28		$this->method = $method;
73	28		$this->get = $get;
74	28		$this->post = $post;
75	28		$this->server = $server;
76	28		$this->cookie = $cookie;
77	28		foreach ($headers as $key => $value) {
78	5		$this->addHeader($key, $value);
79	28		}
80
81	28		$path = $this->get('server', 'REQUEST_URI');
82	28		$parsed = parse_url($path);
83	28		if (isset($parsed['path'])) {
84	28		$this->uri = $parsed['path'];
85	28		}
86	28		}
87
88	1		public static function createFromGlobals()
			0 ignored issues – show Coding Style introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report `createFromGlobals` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report `createFromGlobals` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report `createFromGlobals` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report `createFromGlobals` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
89			{
90	1		$method = isset($_SERVER['REQUEST_METHOD']) ? $_SERVER['REQUEST_METHOD'] : 'GET';
91	1		$headers = [];
92	1		foreach ($_SERVER as $name => $value) {
93	1		if (substr($name, 0, 5) == 'HTTP_') {
94			$headers[str_replace(' ', '-', ucwords(strtolower(str_replace('_', ' ', substr($name, 5)))))] = $value;
95			}
96	1		}
97
98	1		return new static($method, $_GET, $_POST, $_SERVER, $_COOKIE, $headers);
99			}
100
101			/**
102			* @return string
103			*/
104	19		public function getMethod()
105			{
106	19		return $this->method;
107			}
108
109			/**
110			* @return string
111			*/
112	17		public function getUri()
113			{
114	17		return $this->uri;
115			}
116
117			/**
118			* @param string $source
119			* @param string $key
120			* @param mixed $default
121			*/
122	28		public function get($source, $key, $default = false)
123			{
124	28		if (!in_array($source, ['get', 'post', 'server', 'cookie'])) {
125			return;
126			}
127	28		$data = $this->$source;
128	28		if (isset($data[$key])) {
129	23		return $data[$key];
130			}
131
132	10		return $default;
133			}
134
135			/**
136			* @param string $key
137			*
138			* @return string
139			*/
140	9	View Code Duplication	public function getHeader($key)
			0 ignored issues – show Duplication introduced 2016-07-20 16:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
141			{
142	9		$key = $this->normalizeHeaderName($key);
143	9		if (isset($this->headers[$key])) {
144	5		return $this->headers[$key];
145			}
146	7		}
147
148			/**
149			* @param string $key
150			* @param string $value
151			*/
152	5		public function addHeader($key, $value)
153			{
154	5		$this->headers[$this->normalizeHeaderName($key)] = $value;
155	5		}
156
157			/**
158			* @param string $key
159			*
160			* @return string
161			*/
162	9		protected function normalizeHeaderName($key)
163			{
164	9		return ucwords(str_replace('_', '-', strtolower($key)), '-');
165			}
166			}
167

desarrolla2 / kata1

Request A last analyzed 2016-07-22 13:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Request A
last analyzed 2016-07-22 13:14 UTC