DERHANSEN\SfEventMgt\ViewHelpers\Registration\Field\PrefillFieldViewHelper

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	initializeArguments()	0	4	1
A	render()	0	14	2
A	getFieldValueFromSubmittedData()	0	10	3

<?php

/*
 * This file is part of the Extension "sf_event_mgt" for TYPO3 CMS.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

namespace DERHANSEN\SfEventMgt\ViewHelpers\Registration\Field;

use DERHANSEN\SfEventMgt\Domain\Model\Registration\Field;
use DERHANSEN\SfEventMgt\ViewHelpers\AbstractPrefillViewHelper;

/**
 * PrefillField ViewHelper for registration fields
 */
class PrefillFieldViewHelper extends AbstractPrefillViewHelper
{
    /**
     * Initialize arguments
     */
    public function initializeArguments()
    {
        parent::initializeArguments();
        $this->registerArgument('registrationField', 'object', 'The registrationField object', true);
    }

    /**
     * Returns a string to be used as prefill value for the given registration field (type=input). If the form
     * has already been submitted, the submitted value for the field is returned.
     *
     * @return string
     */
    public function render()
    {
        /** @var Field $registrationField */
        $registrationField = $this->arguments['registrationField'];

        // If mapping errors occured for form, return value that has been submitted from POST data
        $originalRequest = $this->renderingContext->getRequest()->getOriginalRequest();

The method getRequest() does not exist on TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface. It seems like you code against a sub-type of TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface such as TYPO3\CMS\Fluid\Core\Rendering\RenderingContext.

        if ($originalRequest) {
            $registrationData = $originalRequest->getParsedBody()[$this->getPluginNamespace($originalRequest)] ?? [];
            return $this->getFieldValueFromSubmittedData($registrationData, $registrationField->getUid());

It seems like $registrationField->getUid() can also be of type null; however, parameter $fieldUid of DERHANSEN\SfEventMgt\ViewHelpers\Registration\Field\PrefillFieldViewHelper::getFieldValueFromSubmittedData() does only seem to accept integer, maybe add an additional type check?

        }

        return $registrationField->getDefaultValue();
    }

    /**
     * Returns the submitted value for the given field uid
     *
     * @param array $submittedData
     * @param int $fieldUid
     * @return string
     */
    protected function getFieldValueFromSubmittedData(array $submittedData, int $fieldUid): string
    {
        $result = '';
        foreach ($submittedData['registration']['fields'] ?? [] as $submittedFieldUid => $fieldValue) {
            if ((int)$submittedFieldUid === $fieldUid) {
                $result = $fieldValue;
            }
        }

        return $result;
    }
}