| Conditions | 2 |
| Paths | 2 |
| Total Lines | 67 |
| Code Lines | 46 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 60 | protected function isEventAvailableInLanguage(int $eventId, int $language): bool |
||
| 61 | { |
||
| 62 | $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class) |
||
| 63 | ->getQueryBuilderForTable('tx_sfeventmgt_domain_model_event'); |
||
| 64 | if ($language === 0) { |
||
| 65 | $where = [ |
||
| 66 | $queryBuilder->expr()->or( |
||
| 67 | $queryBuilder->expr()->eq( |
||
| 68 | 'sys_language_uid', |
||
| 69 | $queryBuilder->createNamedParameter($language, Connection::PARAM_INT) |
||
| 70 | ), |
||
| 71 | $queryBuilder->expr()->eq( |
||
| 72 | 'sys_language_uid', |
||
| 73 | $queryBuilder->createNamedParameter(-1, Connection::PARAM_INT) |
||
| 74 | ) |
||
| 75 | ), |
||
| 76 | $queryBuilder->expr()->eq('uid', $queryBuilder->createNamedParameter($eventId, Connection::PARAM_INT)), |
||
| 77 | ]; |
||
| 78 | } else { |
||
| 79 | $where = [ |
||
| 80 | $queryBuilder->expr()->or( |
||
| 81 | $queryBuilder->expr()->and( |
||
| 82 | $queryBuilder->expr()->eq( |
||
| 83 | 'sys_language_uid', |
||
| 84 | $queryBuilder->createNamedParameter(-1, Connection::PARAM_INT) |
||
| 85 | ), |
||
| 86 | $queryBuilder->expr()->eq( |
||
| 87 | 'uid', |
||
| 88 | $queryBuilder->createNamedParameter($eventId, Connection::PARAM_INT) |
||
| 89 | ) |
||
| 90 | ), |
||
| 91 | $queryBuilder->expr()->and( |
||
| 92 | $queryBuilder->expr()->eq( |
||
| 93 | 'l10n_parent', |
||
| 94 | $queryBuilder->createNamedParameter($eventId, Connection::PARAM_INT) |
||
| 95 | ), |
||
| 96 | $queryBuilder->expr()->eq( |
||
| 97 | 'sys_language_uid', |
||
| 98 | $queryBuilder->createNamedParameter($language, Connection::PARAM_INT) |
||
| 99 | ) |
||
| 100 | ), |
||
| 101 | $queryBuilder->expr()->and( |
||
| 102 | $queryBuilder->expr()->eq( |
||
| 103 | 'uid', |
||
| 104 | $queryBuilder->createNamedParameter($eventId, Connection::PARAM_INT) |
||
| 105 | ), |
||
| 106 | $queryBuilder->expr()->eq( |
||
| 107 | 'l10n_parent', |
||
| 108 | $queryBuilder->createNamedParameter(0, Connection::PARAM_INT) |
||
| 109 | ), |
||
| 110 | $queryBuilder->expr()->eq( |
||
| 111 | 'sys_language_uid', |
||
| 112 | $queryBuilder->createNamedParameter($language, Connection::PARAM_INT) |
||
| 113 | ) |
||
| 114 | ) |
||
| 115 | ), |
||
| 116 | ]; |
||
| 117 | } |
||
| 118 | |||
| 119 | $eventsFound = $queryBuilder |
||
| 120 | ->count('uid') |
||
| 121 | ->from('tx_sfeventmgt_domain_model_event') |
||
| 122 | ->where(...$where) |
||
| 123 | ->executeQuery() |
||
| 124 | ->fetchOne(); |
||
| 125 | |||
| 126 | return $eventsFound > 0; |
||
| 127 | } |
||
| 129 |